Comments (6)
Wouldn't be good if we let the app (I think this is what you meant by conf) decide when Ramadan is, then tell ITL through a flag to bump it to 120?
from itl.
I think you both have the same idea. +1
from itl.
You can use the hijri converter of ITL to create your isRamadan function. However, for the front-end of an app, I recommend having an option to manually adjust the hijri calendar (e.g. plus or minus one day), as Islamic countries, currently, decide the first day of Ramadan using different methods or different regulations/interpretations, leading to two or more Ramadan start dates among those countries.
from itl.
I wouldn't consider this as a fix Ameir. The 120 minutes used in Ramadan is just to give extra half hour for people to eat after Maghrib. Therefore, I wouldn't consider this as a bug. Maybe "nice-to-have" feature since anyhow in Ramadan, people go Isha after hearing Athan from local mosques and not using ITL :-D
from itl.
Looking at getMethod() where the Isha interval is set, I think the best way to handle this is to have another value in the methods enum called UMM_ALQURRA_RAMADAN that sets the interval to 120. It would then be the responsiblity of the client using the library to pass in either UMM_ALQURRA or UMM_ALQURRA_RAMADAN based on its own determination of whether or not this calculation is for ramadan.
If no one has any objections, I will make a pull request for this change.
from itl.
@mohamed still, apps using ITL should reflect the prayer time in the area.
from itl.
Related Issues (17)
- Add Travis CI badge to the readme HOT 1
- Moving from github to gitorious HOT 4
- JavaScript port HOT 1
- UOIF Calculation Method HOT 1
- Objective-C interface
- Java Port HOT 8
- Update the prayer times calculations HOT 37
- swig and debian directories HOT 1
- Egypt General Authority of Survey HOT 1
- Extreme latitude methods HOT 1
- Make library thread-safe
- Move programs/ and ports/ into separate repos HOT 2
- Project homepage ? HOT 2
- DST needs correction
- The clarification of the difference between G2H and and h_date (Documentation) HOT 1
- Test Suite HOT 15
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from itl.