Code Monkey home page Code Monkey logo

Comments (4)

Shazad-khan avatar Shazad-khan commented on July 3, 2024 1

@Nikhil-Nandagopal Just want to call out two consequences if workspaces can have same names:

  1. Users might mistakenly modify or delete data in the wrong workspace, believing it to be another due to the same name.
  2. Because of same names, there could be a confusion and admins might share a wrong workspace with other users and this can cause authorization issues

from appsmith.

Nikhil-Nandagopal avatar Nikhil-Nandagopal commented on July 3, 2024

Sorry but this isn't a hard requirement. Workspace names do not need to be unique

from appsmith.

KrishnaSaiVadlamani avatar KrishnaSaiVadlamani commented on July 3, 2024

Hi @Nikhil-Nandagopal ,

It is okay to have duplicate name,

but there is a logic in frontend, that incrementally creates new names

for example: untitled workspace 1, untitled workspace 2, ....

but this logic also fails, when you hit new workspace button quickly,

so I have added debounce to solve this problem

and in the rare case two users of same workspace from different tabs try to create new application, in then still you will see two "untitled workspace 3" as this is how the current logic it.

so to solve that issue, we are adding a 3 digit random string in the name to make it look like "untitled workspace 3-abd"

let us know your thoughts, here is the pr for the solution I am proposing
#34352

and this is the loom video
https://www.loom.com/share/2d0fa9816e494d6aaa7c2ac243f796ec?sid=1349383e-f083-4d72-9a59-909ae75230e0

from appsmith.

Nikhil-Nandagopal avatar Nikhil-Nandagopal commented on July 3, 2024

@KrishnaSaiVadlamani I understand the problem but it's not a problem worth solving and it's overkill so we'll just ignore it for now.

from appsmith.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.