Comments (5)
R CMD check --as-cran
reports:
- 1 warning, mostly
Undocumented arguments in documentation object {Component}
andDocumented arguments not in \usage in documentation object {Component}
- 3 notes:
- package size exceeds allowed 5Mb
sub-directories of 1Mb or more: doc 4.9Mb www 4.7Mb
Unexported object imported by a ':::' call: ‘shiny:::resolve’
- Multiple:
\examples lines wider than 100 characters
- package size exceeds allowed 5Mb
from shiny.fluent.
When components are generated using shiny.fluent:::component
factory the ...
argument is not documented which results in e.g. Undocumented arguments in documentation object 'Toggle' ‘...’
. It can be resolved using e.g.
# components.R
component <- function(name) {
function(...) shiny.react::reactElement(
module = "@fluentui/react", name = name,
props = shiny.react::asProps(...),
deps = shinyFluentDependency()
)
}
#' Ellipsis documentation template
#' @name doc
#' @param ... Props to pass to \code{shiny.react::reactElement}. See allowed props listed below
NULL
#' @rdname Toggle
#' @inheritParams doc
#' @export
Toggle <- component("Toggle")
But then it prepends ellipsis to the list of arguments of every component
This is in line with actual usage of components as every prop needs to be passed as a named argument using ellipsis, but on the other hand documentation is actually "duplicated" as each prop is contained in ellipsis and it may be confusing.
This "See allowed props listed below" comment may do the job IMO, but do you know any other way how to combine those arguments together in docs? @kamilzyla
Similar thing could be applied to create documentation for {Component}.shinyInput
and update{Component}.shinyInput
(session
, value
, inputId
) arguments. It would get rid of a huge portion of R CMD check
notes.
from shiny.fluent.
Is it any update about the CRAN submission? I tried to install the package for testing purposes from CRAN and it is yet not available (shiny.react it is).
Many thanks,
Corina
from shiny.fluent.
submitting the package to CRAN is still in progress, but you can always install the package from GitHub using:
remotes::install_github("Appsilon/shiny.react")
remotes::install_github("Appsilon/shiny.fluent")
from shiny.fluent.
To close this issue those must be closed first:
from shiny.fluent.
Related Issues (20)
- downloadHandler doesn’t work with shiny.fluent in R v4.2.2 HOT 4
- Sidebar collapse to menu button which does not respond HOT 1
- Stack blocks off event bubbling up HOT 2
- Relative links in R documentation does not work in RStudio Help HOT 3
- Improve documentation for unsupported features with workarounds HOT 1
- Not rendering the content in the second PivotItem HOT 4
- shiny.fluent::runExample("demo") returns Error in $: $ operator is invalid for atomic vectors
- Download links and downloadHandlers do not work from inside a PivotItem HOT 3
- Temporary alert for application users HOT 1
- [docs] add shiny.router on DESCRIPTION HOT 1
- selected item in navigation bar after clicking route_link HOT 2
- Refactor E2E tests to make them more resilient and easy to maintain
- Move CommandBar binding to JavaScript
- 'TimePicker' is not an exported object from 'namespace:shiny.fluent'
- The PivotItem resets state whenever the tab is changed HOT 2
- Enable reactableOutput to be used in shiny.fluent HOT 2
- Errors do not propagate into R console
- Add few examples for R users how to work the DetailsList
- Bugs: cannot provide/override props of SpinButton.shinyInput HOT 1
- `SpinButton.shinyInput` uses `value` improperly
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shiny.fluent.