Comments (3)
I understand it doesn't follow the Ring Adapter Spec.
Can you describe a use-case in which you will use Donkey with an adapter?
You can achieve what you want by creating a server with a single route that delegates to the adapter.
See: https://github.com/AppsFlyer/donkey#reitit
Let me know if I misunderstood.
from donkey.
Its a minor issue, the benefit of following the adapter spec is slightly easier to switch back and forth between different servers from a Ring app. Donkey is compatible with Ring handlers and middlewares, and that's the crux of a Ring app, so the adapter part is very minor, but since Donkey is so close to being fully compliant with Ring, I thought I'd open an issue.
from donkey.
I see.
OK, that's good that you pointed it out.
However, looking at the example you posted, it will make for an awkward API when added to the existing one.
Given that it's entirely possible to use an adapter today, I opt not to implement it.
from donkey.
Related Issues (11)
- Middleware documentation is not clear HOT 1
- Does Donkey support HTTP/2 for gRPC? HOT 2
- stopping a server HOT 1
- wrap-resource causes 500 on match HOT 9
- Way to close Donkey (and underlying Vertx) HOT 2
- WebSockets HOT 2
- Please add the required Clojure version to the "Requirements" section
- Reduce boilerplate code using Lombok
- Ability to combine with existing Vertx libraries HOT 1
- Project still maintained ? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from donkey.