Code Monkey home page Code Monkey logo

Comments (5)

gomoripeti avatar gomoripeti commented on July 25, 2024

thank you for this ticket - btw what version of xprof do you use?

this deprecation notice is only a warning (many erlang libraries are hit by this) but specifically jsone sets the compile flag warnings_as_errors so this warning actually blocks the build. As I see there is already a PR in progress to fix this in jsone (sile/jsone#34)

  • when a new version of jsone is published with this fix you can specify that version in your top mix file (to override version specified by xprof) and that should help
  • until then you can probably override jsone with {erl_opts, [inline]} to remove the warnings_as_errors directive - I am not sure about the exact syntax of override in a mix file

This should help to address this particular issue, but tbh we haven't thoroughly tested with Erlang 21 (and we still need to support Erlang 16 so that puts some limitation on how fast we can go) so there might be some other issues coming up. Please keep us posted.

from xprof.

DianaOlympos avatar DianaOlympos commented on July 25, 2024

Hi, this has been fixed since jsone 1.4.6, see here sile/jsone#35 (comment)

Of course it is not a small bump, so it may needs a lot of testing for your depth of versions ...

from xprof.

gomoripeti avatar gomoripeti commented on July 25, 2024

Thanks for the heads up @DianaOlympos.
I bumped jsone version to 1.4.7 on the release_2.0 branch (PR #143) and it will be included in the next 2.0.0 rc.
Let me know if someone would need this change backported to 1.x

from xprof.

Santiniis avatar Santiniis commented on July 25, 2024

@gomoripeti Are you sure that jsone was the only dependency that needs a bump? I believe that the stack traces warning for OTP21 were only addressed in Cowboy 2.5.0.

from xprof.

gomoripeti avatar gomoripeti commented on July 25, 2024

@Santiniis you are absolutely right, thanks for the heads up. (I probably had cowboy already compiled with some older OTP and forgot to recompile.)
I did not put too much emphasis on cowboy versions as XProf itself can use any cowboy, it hardly uses a few HTTP GETs. So the parent project can decide which cowboy to use (Or if it does not use cowboy for other things do a rebar3 override on xprof_gui) Unfortunately (back when I last tried 1-2 years ago) rebar3 did not support the "~2.0.0" or "at least" notation.
Anyway I don't see any reason why not to bump also the default cowboy version of xprof.

from xprof.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.