Code Monkey home page Code Monkey logo

Comments (6)

simontabor avatar simontabor commented on September 21, 2024

@mirek why was this done? 315e9e2

i assume it's to stop big changes for each commit, maybe we should use git-lfs?

from b-privacy-js.

mirek avatar mirek commented on September 21, 2024

You can add npm run build in postinstall or prepublish. Does keeping it in git gives you any advantages?

from b-privacy-js.

simontabor avatar simontabor commented on September 21, 2024

from b-privacy-js.

mirek avatar mirek commented on September 21, 2024

Yes, but be careful - for prepublish to include it in the distribution it would have to be un-ignored. If you add .npmignore - it'll ignore all ignore definitions in .gitignore so the best is to copy it over - without node_modules and dist.

from b-privacy-js.

mirek avatar mirek commented on September 21, 2024

But normally your react-app stuff should just pick up this package without dist, package it itself and you should be able to use it from the bundle, no?

from b-privacy-js.

simontabor avatar simontabor commented on September 21, 2024

webpack doesn't try to apply transformations on modules, so for that to work you need to configure webpack to treat b-privacy as if it's our own react code

from b-privacy-js.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.