Code Monkey home page Code Monkey logo

Comments (4)

holzensp avatar holzensp commented on May 23, 2024 1

This is wild! I managed to reproduce. Thanks for the bug report.

from pkl.

translatenix avatar translatenix commented on May 23, 2024

I don't think this is a bug.
The documentation of List.sortWith says:

comparator should return true if its first argument comes before its second argument in the sort order, and false otherwise.

So it should be local com = (a, b) -> a > b instead of local com = (a, b) -> a >= b.

I checked Swift's and Scala's sortWith functions, and they have the same requirement. Swift additionally states that the comparator function must be irreflexive.

from pkl.

jw-y avatar jw-y commented on May 23, 2024

Either case, I don't think this is any way intended.

FYI,
found the location of the bug.

if (comparator.executeWith(array[mid], array[mid], function)) {

first mid should be mid-1

from pkl.

translatenix avatar translatenix commented on May 23, 2024

That indeed looks like a bug. I guess a reflexive comparator function should only give you an unstable/inefficient sort, not a wrong sort.

from pkl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.