Code Monkey home page Code Monkey logo

Comments (6)

diemol avatar diemol commented on July 21, 2024 4

Maybe you can follow the same pattern as in docker-selenium https://github.com/SeleniumHQ/docker-selenium/wiki/Tagging-Convention
E.g.: Selenium version 3.4.0, docker-selenium tag -> 3.4.0-chromium

In my opinion, it should be easy to understand for anyone which version of Appium is being used. This will facilitate a lot bug reporting and related issues.

from appium-docker-android.

SrinivasanTarget avatar SrinivasanTarget commented on July 21, 2024

Ah makes sense. Will check.

from appium-docker-android.

budtmo avatar budtmo commented on July 21, 2024

We have already release tag 2.0-barcelona. If we make appium version as tag then the version of docker image and release tag will be decreased, e.g. 1.6.6-beta. Maybe we can put appium version in readme and release note.

from appium-docker-android.

serggl avatar serggl commented on July 21, 2024

actually 2.0-barcelona is a bad tag name. 1.6.6-beta is a proper one semantically. Just take a look how ruby team maintains their repository https://hub.docker.com/_/ruby/

from appium-docker-android.

budtmo avatar budtmo commented on July 21, 2024

@serggl The issue that I want to point out is not the name, but the version. :)
If we use appium version as tag then the version of docker-image and release tag will be decreased, e.g. from 1.1 to 2.0 and then become 1.6.6 which do not make sense in my opinion, unless we delete version 2.0. but I think @SrinivasanTarget can decide.

from appium-docker-android.

serggl avatar serggl commented on July 21, 2024

@butomo1989 I dont think that docker hub tags should exactly match this repo 'release tags'.
But

  1. it should be clear from the dockerhub tags which version of appium you're pulling
  2. dockerhub tags should be immutable (except of the latest). So once you decide to roll out appium upgrade - tag name should differ

but this is not what currently happening

from appium-docker-android.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.