Remove polyfill packages about polly HOT 7 CLOSED

The System.Diagnostics.DiagnosticSource is only included on netstandard2.0 net472 net462 and we cannot really use the one that is provided by .NET Framework. This is because we are using APIs that are only available on newer version of the library.

If I add System.Diagnostics.DiagnosticSource as per your suggestion:

  <ItemGroup>
    <PackageReference Include="Microsoft.Extensions.Options" />
    <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" />
    <Reference Include="System.Net.Http" Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'" />
    <Reference Include="System.Diagnostics.DiagnosticSource" Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'" />
  </ItemGroup>

The Polly.Extensions cannot be built anymore:

from polly.

I'm lead to believe that removing dependencies is a breaking change (in fact, I hit this today in #2003 due to changes to Microsoft.Extensions.TimeProvider.Testing dropping seemingly redundant dependencies), so if that's the case this isn't something we'd do until there's a reason for a Polly v9 if we did.

from polly.

In the case here I am referring to polyfill package's ie ones which are natively provided by the framework without it needing to be explicitly added hence I don't see it as a breaking change.

from polly.

Yes I understand that, and this comment is what lead me to my comment: dotnet/extensions#5058 (review)

And also the fact that it actually broke the build in #2056 when I updated to Microsoft.Extensions.TimeProvider.Testing 8.4.0 without me adding the reference.

from polly.

I am still talking about polyfill package's and as such if a client is using System.Diagnostic.DiagnosticSource in their application/library it will still build as the framework will provide the library and likely even provide a newer version.

from polly.

@martintmk let me submit a PR tomorrow my time showing the change as your sample code is not quite what I am intending.

from polly.

Issue has been addressed already as part of the 8.4.0 release which has occured, hence closing issue

from polly.