Code Monkey home page Code Monkey logo

Comments (3)

ApoorvSaxena avatar ApoorvSaxena commented on May 18, 2024

Hi! Thanks for the awesome library!

Your welcome :)

Regarding:

I was wondering if it would be an idea to actually test for the img element in the check that you do? Seeing that the src attribute can only be applied to a limited amount of elements, it would be easy to test for those and add specific functionality for them, and otherwise for background images. This way we can give the background image a regular data-src as well, instead of the data-background-image we've got now.

Can you share an example where the image needs a src and background-image as well?

from lozad.js.

aderaaij avatar aderaaij commented on May 18, 2024

Oh absolutely never! I was strictly talking about data attribute naming. data-background-image does make sense but I just thought that it might be safer to test on tagname in general.

from lozad.js.

ApoorvSaxena avatar ApoorvSaxena commented on May 18, 2024

@aderaaij considering that Lozad.js allows lazy loading of several other elements such as iframes, video, picture elements etc. as well, thus will be better to have the implementation as is

from lozad.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.