Update OTEL trace_id value from a request header about router HOT 9 OPEN

The router would only originate a trace Id when it doesn't get one from the headers. Do you have tracing propagation setup or any exporters enabled? Can you share more of your configuration?

from router.

Put another way, the thing you're asking for should definitely already work. The router is meant to play nice with existing distributed tracing headers, including passing them to subgraphs as fit.

@BrynCooke Anything to add here?

from router.

The router would only originate a trace Id when it doesn't get one from the headers. Do you have tracing propagation setup or any exporters enabled? Can you share more of your configuration?

I tried it and left comment here. #4823 (comment)

          datadog:
            enabled: true
            enable_span_mapping: true
            batch_processor:
              ...
            endpoint: "xx"
          propagation:
            datadog: true
            request:
              header_name: trace-id

I think it trimmed off the - from UUID. Our downstream received value like traceid=28e9fb547e465690f288cdb96194d119 which failed their UUID validation.

Update: i'll take another look tmr to observe the change.

from router.

I still get a different trace_id than trace-id header used above. The log is from subgraph_service.

And, subgraph would receive this error(invalid UUID) from trace-id header. So somewhere overwrite trace-id header.

Also the following trace ids are mutual exclusive in router span attrs.

      router:
        attributes:
          trace_id: true
          trace-id:
            request_header: trace-id

from router.

In debug mode, I get following error

  "message": "cannot generate custom trace_id: invalid digit found in string",
  "target": "apollo_router::plugins::telemetry",

looks like trace_id is recreated because it couldn't parse UUID header.

from router.