Comments (3)
I agree with this. From our discussion on telegram my understanding is the following:
get-starknet
and wallets return an object that implements theAccountInterface
v4- starknet.js requires now the
AccountInterface
v5
My idea is that for the time being we should wrap the account v4 into a shim that implements the account v5 interface (and throws if the library/dev tries to use a new method).
What do you think?
from starknet-react.
I looked more into this tonight.
- Most changes are caused by
library.chainId
becomingawait library.getChainId()
. We can wrap this into a hook so the change is simple. get-starknet-core
hasstarknet
as a peer dependency. This is what seems to be causing issues.
At the moment and for the next few weeks, all injected wallets will still implement the account interface from v4.
So the only way I see adding support for v5 is by:
- explicitly request a v4 account interface to the wallet
- wrap the v4 account into a shim that implements the v5 interface
- use the shim as the starknet-react provider
in a few weeks/months once v4 is officially deprecated, we can start requesting v5 and discard the shim.
What do you think?
from starknet-react.
v5 is now supported.
from starknet-react.
Related Issues (20)
- Add `providerOrAccount` override to `useContract` HOT 2
- Return connector's chainId in `useAccount` HOT 2
- React Native + PWA demo HOT 7
- Create companion app to deploy arcade accounts HOT 2
- Add welcome + setup screen to Expo demo HOT 3
- Add main app screen to Expo demo HOT 1
- Add settings screen to Expo demo HOT 1
- Add manage account page to companion app HOT 4
- Create arcade account deployer contract
- Add `Explorer` interface and `useExplorer` hook HOT 2
- Using RPC Provider, but 'account' Object Still References 'feederGateway' which is deprecated HOT 2
- Icon error when wallet is not installed HOT 4
- Support for sepolia network on rpc provider from starknet react core HOT 3
- Nethermind provider address changed HOT 2
- Expose useStarknet from the context HOT 5
- Add support for estimate fees and simulate transactions HOT 3
- Error on page demos/contract-read
- useStarkProfile() error on custom chains HOT 3
- Add optional chain argument to starknet.id hooks HOT 7
- How to identify dapp on connect? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from starknet-react.