Code Monkey home page Code Monkey logo

Comments (3)

fracek avatar fracek commented on July 17, 2024

I agree with this. From our discussion on telegram my understanding is the following:

  • get-starknet and wallets return an object that implements the AccountInterface v4
  • starknet.js requires now the AccountInterface v5

My idea is that for the time being we should wrap the account v4 into a shim that implements the account v5 interface (and throws if the library/dev tries to use a new method).

What do you think?

from starknet-react.

fracek avatar fracek commented on July 17, 2024

I looked more into this tonight.

  • Most changes are caused by library.chainId becoming await library.getChainId(). We can wrap this into a hook so the change is simple.
  • get-starknet-core has starknet as a peer dependency. This is what seems to be causing issues.

At the moment and for the next few weeks, all injected wallets will still implement the account interface from v4.
So the only way I see adding support for v5 is by:

  1. explicitly request a v4 account interface to the wallet
  2. wrap the v4 account into a shim that implements the v5 interface
  3. use the shim as the starknet-react provider

in a few weeks/months once v4 is officially deprecated, we can start requesting v5 and discard the shim.

What do you think?

from starknet-react.

fracek avatar fracek commented on July 17, 2024

v5 is now supported.

from starknet-react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.