Code Monkey home page Code Monkey logo

Comments (2)

apeschar avatar apeschar commented on May 23, 2024

Ugh! This was introduced in 1.1.0. I added some logic to remove comments from <script> tags because of an issue with export default being interpreted by the Vue compiler in comments. (See #7.)

But the module that was suggested, and that I used, strip-comments, actually does not properly parse the JavaScript, just uses some string patterns to detect comments. I should've vetted it more thoroughly.

tl;dr: I've removed this "feature" in 1.1.1. After updating, this issue should be fixed.

This still leaves the issue with export default in comments, but ideally this should be fixed in the Vue compiler project.

from esbuild-vue.

iafisher avatar iafisher commented on May 23, 2024

Thank you for the quick response. Can confirm that upgrading to 1.1.1 fixed this issue.

from esbuild-vue.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.