Webpack build runs regardless of BUILD_SUPERSET_FRONTEND_IN_DOCKER cited in docker compose documentation about superset HOT 2 OPEN

Hey there, @jtcurlin! I'm Dosu, a bot here to help you with bugs, questions, and becoming a contributor. Let's squash those bugs together! 🤖

To prevent the frontend build from running in Docker when setting BUILD_SUPERSET_FRONTEND_IN_DOCKER to false within the .env file, you need to ensure that the Dockerfile and related scripts respect this environment variable.

Currently, setting BUILD_SUPERSET_FRONTEND_IN_DOCKER to false only affects the docker/docker-frontend.sh script, which skips the frontend build steps and outputs the message "Skipping frontend build steps - YOU RUN IT MANUALLY ON THE HOST!" ^[1].

However, the npm run build command in the Dockerfile is not conditional on this environment variable. To address this, you can modify the Dockerfile to conditionally run the frontend build based on the BUILD_SUPERSET_FRONTEND_IN_DOCKER variable. Here is an example of how you can modify the Dockerfile:

# Dockerfile
ARG BUILD_SUPERSET_FRONTEND_IN_DOCKER=true

# Other Dockerfile steps...

# Conditionally run the frontend build
RUN if [ "$BUILD_SUPERSET_FRONTEND_IN_DOCKER" = "true" ]; then npm run build; else echo "Skipping frontend build"; fi

This modification ensures that the frontend build only runs if BUILD_SUPERSET_FRONTEND_IN_DOCKER is set to true.

Additionally, if you have less than 16GB of memory, running the frontend build locally can be much faster. You can do this by navigating to the superset-frontend directory and running:

npm install
npm run dev

This will install the necessary dependencies and start the development server for the frontend, allowing you to see changes in real-time ^[1].

For more details on the recent changes to the Dockerfile that might affect the frontend build process, you can refer to the specific updates such as the Node version update, NPM build command argument, memory management script, and translation files handling ^[2].

To continue talking to Dosu, mention @dosu.

from superset.

hey, this is a bit confusing, but BUILD_SUPERSET_FRONTEND_IN_DOCKER affects a subsequent build step in docker/docker-frontend.sh, that's related to firing up docker-compose. The step you refer to above happens much earlier in the docker build process.

Essentially our dev setup is based on our docker builds, and part of that multi-stage / target docker build that somewhere upstreams builds the frontend bundle, only to throw it away / redo it in the late docker-compose build step as npm run dev, which operates off a mount and removes the need for that upstream build.

It would be nice to make that step optional upstream perhaps, but could create other kind of confusion an conflicts. Wondering if simply adding an ARG in our main dockerfile based on BUILD_SUPERSET_FRONTEND_IN_DOCKER would have any downsides (?)

Also hoping that in many cases you could docker pull and operate from cache instead of locally building that layer.

from superset.