Swift SDK does not support self-signed server certificates. about openwhisk-runtime-swift HOT 5 OPEN

@jthomas

In the code above, this won't be the default behaviour. It relies on the user explictly setting a function parameter, which defaults to false. This mirrors the behaviour of the JavaScript SDK.

Sorry read your comment again, I think I missed it the first time.

The default behavior for what ever reason today (ie. 3.1.1) _Whisk class API is blocking: Bool = true different from the JavaScript SDK.
https://github.com/apache/incubator-openwhisk-runtime-swift/blob/master/core/swift3.1.1Action/spm-build/_Whisk.swift#L23

 class func invoke(actionNamed action : String, withParameters params : [String:Any], blocking: Bool = true) -> [String:Any] {

It would be good to have consistency with theJavaScript SDK, but I think is more important to not break people's code by changing the API when they move from swift 3 to swift4.

I think it's something to note when we get to building new Library/SDK for swift4+ both client and server, and maybe a new Class OpenWhisk, then I think will have an opportunity to change the API to invoke

from openwhisk-runtime-swift.

Thanks for opening this.
I thought I already opened an issue to document my findings.

For swift 4 we plan to use urlSession.
Ignoring SSL is not a good thing, so the library should not be supporting this.

I made the SDK to allow to take an override to APIHOST, by allowing the user to specify a baseURL.
In this baseURL user can specify the Whisk API using http instead of https

This allowed me to write test to pass in Travis.

I production system WHISK APIHOST will always be https with valid certificates.
I opened issue #11 and will plan to work on it.

We can leave this issue open until linux supports self sign certs, and then allow an override in the Class to skip ssl checks, but should not be the default.

from openwhisk-runtime-swift.

Here is an example

 //Overriding WHISK API HOST using baseUrl, only applicable in testing with self sign ssl certs"
 Whisk.baseUrl = "http://172.17.0.1:10001"
 let invokeResult = Whisk.invoke(actionNamed: "/whisk.system/utils/date", withParameters: [:], blocking: false)

from openwhisk-runtime-swift.

In the code above, this won't be the default behaviour. It relies on the user explictly setting a function parameter, which defaults to false. This mirrors the behaviour of the JavaScript SDK.

from openwhisk-runtime-swift.

Yep that correct it would no be the default.
Default behavior is that user coding the action doesn’t have to worry the environment variable with APIHOST will be use they don’t have to specify baseURL

from openwhisk-runtime-swift.