Use of request's global cookie `jar` about nano HOT 8 CLOSED

@mikeal is this an issue in request?

+@pgte @indexzero

from nano.

I would like to have this patched in request in everything that concerns http client issues and nano in everything that concerns CouchDB.

I'm still looking at your code and comments and trying to figure this out myself, so I should get back to you soon.

from nano.

I believe the problem is that nano doesn't (perhaps can't) instantiate request. This means that they all reference back to the same place (and therefore the same cookie jar). Try this out for example:

var fn1 = function () {
    var request1 = require('request');
    console.log('Should be undefined', request1.testProp);
    request1.testProp = 1;
    console.log('Should be 1', request1.testProp);
},
fn2 = function () {
    var request2 = require('request');
    console.log('Should be undefined', request2.testProp);
    request2.testProp = 2;
    console.log('Should be 2', request2.testProp);
};

fn1();
fn2();

console.log('Should be undefined', require('request').testProp);

from nano.

my 2 cents: I know that by default request uses the same cookie jar for all requests.
Maybe nano should expose the request options.jar option?

FYI, you can construct a cookie jar in request by calling:

var jar = request.jar()

and you can associate it to a request like this:

request({uri: uri, jar: jar})

if you don't want to use the cookie jar at all just pass jar: false.

from nano.

I agree that this needs to be an option, however I personally believe that the default should be false, as there is no genuine reason for nano using a cookie jar - that I can think of.

Its also confusing because whilst you can create separate instances of nano (and use them in isolation), the underlying request is a reference, not an instance - leading to potential confusion in the area of a jar. IMO

from nano.

nano can default to false.

var request = require('request').defaults({jar:false})

from nano.

Sorry, ignore 8a7fb4d - that was an accidental push! :)

from nano.

This looks awesome. I'll merge and review as soon as I get a free cycle!

from nano.