Comments (4)
I agree with removing the obsolete classes and methods.
I'm not sure about NDC. Looking at the code it seems to be explicitly un-deprecated and there are many uses
https://github.com/search?q=NDC.Push+path%3A*.cs+language%3AC%23&type=Code&ref=advsearch&l=C%23&l=
The class is just a wrapper around ThreadContext.Stacks["NDC"], so the gain for removing it would be small against the anger we could cause ;-)
When we DO want to remove it, we would do it later and first mak it (again) as deprecated.
@fluffynuts what do you think?
from logging-log4net.
I agree - something marked [Obsolete]
can go, something that still works, even if it's only for a few users, can stay. And we should be very judicial about deprecations - I'd much rather keep the library useful for as many people as possible, so even if some part looks unused, if it works, leave it in until there's no other option but to lose it.
from logging-log4net.
OK. I would propose releasing the first 3.0.0 preview with the obsolete classes, so that we could deploy this version in our company and to other "willing" users. Then we remove those classes in the next preview for 3.0.0.
from logging-log4net.
Deleted obsolete API:
- obsolete since 1.2.14 - 2015
log4net.Appender.BufferingAppenderSkeleton.OnlyFixPartialEventData
log4net.Appender.ColoredConsoleAppender.ctor(ILayout)
log4net.Appender.ColoredConsoleAppender.ctor(ILayout, bool)
log4net.Appender.ConsoleAppender.ctor(ILayout)
log4net.Appender.ConsoleAppender.ctor(ILayout, bool)
log4net.Appender.DebugAppender.ctor(ILayout)
log4net.Appender.EventLogAppender.ctor(ILayout)
log4net.Appender.FileAppender.ctor(ILayout, string)
log4net.Appender.FileAppender.ctor(ILayout, string, bool)
log4net.Appender.MemoryAppender.OnlyFixPartialEventData
log4net.Appender.SmtpAppender.LocationInfo
log4net.Appender.TextWriterAppender.ctor(ILayout, Stream)
log4net.Appender.TextWriterAppender.ctor(ILayout, TextWriter)
log4net.Appender.TraceAppender.ctor(ILayout)
log4net.Config.DOMConfigurator
log4net.Config.AliasDomainAttribute
log4net.Config.DomainAttribute
log4net.Config.DOMConfiguratorAttribute
log4net.Core.LoggerManager.GetLoggerRepository
log4net.Core.LoggerManager.CreateDomain
log4net.Core.LoggingEventData.TimeStamp
log4net.Core.LoggingEvent.GetExceptionStrRep
log4net.Core.LoggingEvent.FixVolatileData
log4net.LogManager.GetLoggerRepository
log4net.LogManager.CreateDomain
- obsolete since 2.0.6 - 2016
log4net.Util.SystemInfo.ProcessStartTime
Other changes:
log4net.Config.AliasRepositoryAttribute
is now sealedlog4net.Config.RepositoryAttribute
is now sealedlog4net.Config.XmlConfiguratorAttribute
is now sealed
from logging-log4net.
Related Issues (18)
- Enable automatic test runs on commit
- Cross-database testing
- Release automation (for the most part)
- Fix dotnet (ie not netfx) test run
- NPM script to generate beta packages
- Dropping support for older runtimes HOT 6
- Thread prints generic thread name instead of ID ".NET TP Worker" HOT 1
- [Bug] Android Archiving failing due to file being used by another processes HOT 2
- NullRefException from shutdown in 2.0.16 HOT 11
- Add support for nullable annotations
- Enable building log4net with docker container
- Most links in the documentation are broken HOT 2
- Possible System.IndexOutOfRangeException in AppenderSkeleton.Finalize() HOT 3
- 3.0.0-preview.1 HOT 1
- .NET8.0 XML Exception Problem HOT 12
- Use Logging Services common pages HOT 4
- Add an `Installation` page and rework the `Download` page HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from logging-log4net.