Code Monkey home page Code Monkey logo

Comments (11)

jerqi avatar jerqi commented on May 19, 2024

How much time will it take to execute the operation? Could you provide some concrete data?

from incubator-uniffle.

colinmjj avatar colinmjj commented on May 19, 2024

@xianjingfeng I think clear unnecessary data before start shuffle server by Linux command is a better way, and clear process during shuffle server startup is a backup solution.
I prefer to improve start script to do such thing.

from incubator-uniffle.

xianjingfeng avatar xianjingfeng commented on May 19, 2024

How much time will it take to execute the operation? Could you provide some concrete data?

more that 30 seconds per disk, it dependency disk performance and usage.

from incubator-uniffle.

jerqi avatar jerqi commented on May 19, 2024

How much time will it take to execute the operation? Could you provide some concrete data?

more that 30 seconds per disk, it dependency disk performance and usage.

What's the type of disk that you use? The performance of disk is a little strange. We only delete one directory on every disk, it shouldn't take so much time.

from incubator-uniffle.

xianjingfeng avatar xianjingfeng commented on May 19, 2024

How much time will it take to execute the operation? Could you provide some concrete data?

more that 30 seconds per disk, it dependency disk performance and usage.

What's the type of disk that you use? The performance of disk is a little strange. We only delete one directory on every disk, it shouldn't take so much time.

hdd, about 1T usage per disk

from incubator-uniffle.

xianjingfeng avatar xianjingfeng commented on May 19, 2024

@xianjingfeng I think clear unnecessary data before start shuffle server by Linux command is a better way, and clear process during shuffle server startup is a backup solution. I prefer to improve start script to do such thing.

if do this in start scirpt, we need parse conf file in start script, i think it is heavy for start script and it is difficult to maintain

from incubator-uniffle.

xianjingfeng avatar xianjingfeng commented on May 19, 2024

How much time will it take to execute the operation? Could you provide some concrete data?

more that 30 seconds per disk, it dependency disk performance and usage.

What's the type of disk that you use? The performance of disk is a little strange. We only delete one directory on every disk, it shouldn't take so much time.

FileUtils.deleteDirectory will delete it's childrens first

from incubator-uniffle.

jerqi avatar jerqi commented on May 19, 2024

How much time will it take to execute the operation? Could you provide some concrete data?

more that 30 seconds per disk, it dependency disk performance and usage.

What's the type of disk that you use? The performance of disk is a little strange. We only delete one directory on every disk, it shouldn't take so much time.

FileUtils.deleteDirectory will delete it's childrens first

Ok, I got it. It's ok for me to use multi-thread to do cleanup operation.

from incubator-uniffle.

frankliee avatar frankliee commented on May 19, 2024

How much time will it take to execute the operation? Could you provide some concrete data?

more that 30 seconds per disk, it dependency disk performance and usage.

What's the type of disk that you use? The performance of disk is a little strange. We only delete one directory on every disk, it shouldn't take so much time.

FileUtils.deleteDirectory will delete it's childrens first

How much time will it take to execute the operation? Could you provide some concrete data?

more that 30 seconds per disk, it dependency disk performance and usage.

What's the type of disk that you use? The performance of disk is a little strange. We only delete one directory on every disk, it shouldn't take so much time.

hdd, about 1T usage per disk

How many files are deleted in your disk ? Uniffle has merged data in each partition, so there will not exist very large number of files. Can you do a simple test by using rm -rf

from incubator-uniffle.

xianjingfeng avatar xianjingfeng commented on May 19, 2024

How much time will it take to execute the operation? Could you provide some concrete data?

more that 30 seconds per disk, it dependency disk performance and usage.

What's the type of disk that you use? The performance of disk is a little strange. We only delete one directory on every disk, it shouldn't take so much time.

FileUtils.deleteDirectory will delete it's childrens first

How much time will it take to execute the operation? Could you provide some concrete data?

more that 30 seconds per disk, it dependency disk performance and usage.

What's the type of disk that you use? The performance of disk is a little strange. We only delete one directory on every disk, it shouldn't take so much time.

hdd, about 1T usage per disk

How many files are deleted in your disk ? Uniffle has merged data in each partition, so there will not exist very large number of files. Can you do a simple test by using rm -rf

I neither count how many files nor test by using rm -rf , i will try to do this recently

from incubator-uniffle.

jerqi avatar jerqi commented on May 19, 2024

solved by pr #72

from incubator-uniffle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.