Code Monkey home page Code Monkey logo

examples's Introduction

Examples for Apache Fluo

Build Status Apache License

examples's People

Contributors

cjnolet avatar ctubbsii avatar dependabot[bot] avatar ericnewton avatar joshelser avatar keith-turner avatar kennethmcfarland avatar mikewalch avatar

Stargazers

 avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

examples's Issues

Re-enable ITs and QA plugins

Findbugs and ITs were disabled in #14 to get the basic build to work. These should be re-enabled once the issues preventing them from working are solved.

Webindex PageLoader null handling

webindex.data.fluo.PageLoader does not check for null inputs. When dereferencing the object to see if it is empty it doesn't first check to make sure the object exists. I wrote a simple test to show this below.

This is line 45 - 50 that shows why it happens

public static PageLoader updatePage(Page page) {
    Preconditions.checkArgument(!page.isEmpty(), "Page cannot be empty");
    PageLoader update = new PageLoader();
    update.action = Action.UPDATE;
    update.page = page;
    return update;
  }
package webindex.fluo;

import org.junit.Test;

import webindex.core.models.Page;
import webindex.data.fluo.PageLoader;

public class PageLoaderTest {

	@Test
	public void testNullPage() {
		Page p = null;
		PageLoader loader = PageLoader.updatePage(p);
	}
	
	@Test(expected = IllegalArgumentException.class)
	public void testEmptyPageThrowsIllegalArgument() {
		Page p = Page.EMPTY;
		PageLoader loader = PageLoader.updatePage(p);
	}

}

Webdndex PageLoader refactoring

In response to #8 there should be minor refactoring of the PageLoader class. This refactoring will make sure that this class passes the agreed test cases that are created and implemented in issue #8

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.