Comments (10)
raphinesse
commented on May 30, 2024
2
@brodybits @janpio Links to the test failures in the CI logs would be helpful.
from cordova-lib.
janpio
commented on May 30, 2024
2
Rebased #696 onto master including #698 indeed did fix the build.
Thanks @raphinesse and @brodybits.
from cordova-lib.
raphinesse
commented on May 30, 2024
1
@janpio you have to click "View Details" where it says that the PR has been merged.
from cordova-lib.
janpio
commented on May 30, 2024
The change proposed in GH-691 did pass AppVeyor CI before it was merged.
#691 doesn't list any CI checks being run: https://github.com/apache/cordova-lib/pull/691/checks Am I missing something? Were those removed after merge?
Right now it seems to me the test is consistently failing since #691.
from cordova-lib.
raphinesse
commented on May 30, 2024
Curiously, Travis CI was configured to only test with Node 4 and 6 when cordova-windows 6 was tagged
from cordova-lib.
janpio
commented on May 30, 2024
Failing tests on merge to master are at https://ci.appveyor.com/project/Humbedooh/cordova-lib/build/1.0.2814/job/pbmia5soyvei4bc4. Same test failures for PRs started after that commit (e.g. #696)
from cordova-lib.
brodybits
commented on May 30, 2024
I just merged #698 which was green, hope change in #698 will be green in master.
from cordova-lib.
raphinesse
commented on May 30, 2024
@janpio I created #698 for those. But these tests do not even use cordova-browser. They use cordova-android as a test platform
from cordova-lib.
janpio
commented on May 30, 2024
I don't even fake that I understand what the tests are doing - so I'm just happy you both seem to have found a way to fix this 💯
from cordova-lib.
brodybits
commented on May 30, 2024
Latest commit in master is now green, closing now. I hope this will solve the failure on #696.
from cordova-lib.
Related Issues (20)
- Cordova does not support subfolders, when using semver
- Cordova platform add android, removes node modules with semver HOT 3
- Improve how Cordova checks for required project information HOT 1
- plugin.xml <dependency> tag commit attribute doesn't work as documented for branches HOT 1
- cordova prepare not resolving platform specification correctly for devDependency HOT 1
- NodeJS14: Warning: Accessing non-existent property 'android' HOT 3
- Unable to remove a plugin using a not officially supported platform HOT 1
- Process.env variables are not present in hooks HOT 1
- Cordova doesn't work with NPM 7 HOT 15
- Failure to install plugin with url#git_ref:subdir spec HOT 1
- One test fails on CI HOT 1
- Wrong platform version is detected when dependencies and devDependencies are both present HOT 1
- Fail to add plugin with prerelease version because of "Invalid Version" HOT 1
- Dependencies are wiped on each step of project creation with cordova-lib and NPM 7 HOT 2
- Question About API 24 And API 30 And Question About How Make Jar Using Cordova 9.1.0 And Cordova 10.0.0 (Solution for jcenter() deprecated) HOT 1
- restore-util doesn't properly find platform spec info
- Adding plugins for only specific platforms HOT 10
- Cordova uses the wrong working directory and loads top-level config.xml HOT 1
- Bug(tests): Test#012 failure HOT 5
- Why cordova-android 12.0.0 is not used ? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cordova-lib.