New logic for setting attributes in package.json & config.xml (§3) about cordova-create HOT 5 CLOSED

From @dpogue on July 17, 2018 17:18

If we're wanting to read/write name and version from package.json, I can add getters/setters for those in my proposed PackageHelper in cordova-common.

from cordova-create.

For the record, currently I do not believe Cordova looks at package.json for an app ID or app version, it expects those to only live in config.xml on the widget tag. So setting them in package.json is nice from a consistency perspective, but doesn't actually impact Cordova behaviour.

I think that's fine the way it is, we shouldn't attempt to move those out of config.xml at this point.

from cordova-create.

@dpogue It's good to know that Cordova does not really look at version and name of package.json. But that does not mean that we cannot setup a consistent project for the user. Frankly, that's the least I would expect as a user.

I think that's fine the way it is, we shouldn't attempt to move those out of config.xml at this point.

I'm not sure I understand that part. I'm not trying to move anything anywhere. I'm only trying to make cordova-create respect the values present in the template files used to create the new project. And be consistent in doing so. Do you think we should not do that?

from cordova-create.

If we're creating a new project, then yeah, it makes sense to set the name and version in package.json as well.

What I don't want to do (at this point anyways) is make changes to cordova-lib to read those values out of package.json instead of config.xml.

from cordova-create.

@dpogue Alright, the latter was never intended

from cordova-create.