Comments (6)
Thanks @Lordworms. I'm thinking about @alamb's idea #10879 (comment), which only implements contains
as a placeholder for translating/planning. And it would finally become some other thing like LIKE
after the optimization phase. A similar thing is Expr::Wildcard
, it's to reflect *
from SQL but doesn't have a corresponding physical expr.
from arrow-datafusion.
I'll refactor it to use LIKE
from arrow-datafusion.
cc @Lordworms
from arrow-datafusion.
Sorry for the late review since I was busy this week. In the beginning, I was just trying to keep the same format as other ScalarUDF which utilize arrow-rs methods to implement functionality so I just chose arrow::reglike. I can fix it to use str.contains
from arrow-datafusion.
I was just trying to keep the same format as other ScalarUDF which utilize arrow-rs methods to implement functionality so I just chose arrow::reglike.
Makes sense. I think in this case, however, the function shouldn't actually have regexp support, so it would be better to use str.contains
I can fix it to use str.contains
Thank you!
from arrow-datafusion.
One benefit of using LIKE
is that it already has a highly optimized arrow implementation (as in will actually use substring if the patttern looks like substr%
etc).
from arrow-datafusion.
Related Issues (20)
- `BinaryExpr` evaluate lacks optimization for `Or` and `And` scenarios HOT 12
- Register SQL planners in `SessionState::new()` HOT 4
- Implement user defined planner for `date_part`
- Implement user defined planner for `create_struct` HOT 1
- Implement user defined planner for `create_named_struct` HOT 1
- Implement user defined planner for `sql_overlay_to_expr` HOT 1
- BinaryOp supporting multiple parameters in Substrait
- Support `COUNT()` in addition to `COUNT(*)` HOT 1
- Replace `println!` with `assert!` if possible in DataFusion examples HOT 3
- Implement Substrait support for SubqueryType::Scalar
- HashJoin for nested types give wrong results
- Clean Up Data Page Statistics Tests HOT 1
- Implement user defined planner for sql_position_to_expr
- Implement user defined planner for `sql_compound_identifier_to_expr`
- Implement user defined planner for `sql_substring_to_expr `
- Implement user defined planner for `sql_position_to_expr`
- `where` clause incorrectly reject `NULL` literal (by SQLancer-NoREC)
- Make error message better when `bitwise_*` operator takes wrong argument type
- Improve error message for wrong argument type in operators
- Error evaluating clause `where COL_BIGINT < 1e100` (Found by SQLancer-NoREC) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from arrow-datafusion.