Comments (9)
Lordworms
commented on August 25, 2024
1
take
from arrow-datafusion.
alamb
commented on August 25, 2024
1
I am not sure @Lordworms -- maybe @waynexia or @Blizzara have more context / understanding
@richtia does this request come from a particular query you are runniing?
from arrow-datafusion.
richtia
commented on August 25, 2024
1
My preference would actually be to add the function as well. The request came from trying to run a query with the contains function.
from arrow-datafusion.
Blizzara
commented on August 25, 2024
1
+1 to adding the function into DataFusion (+ the relevant mapping into Substrait) if it doesn't exist yet.
Seems like Arrow has a contains function but I cannot find it in DataFusion so maybe it doesn't indeed exist yet, dunno if the Arrow version can somehow be easily used?
from arrow-datafusion.
Lordworms
commented on August 25, 2024
1
+1 to adding the function into DataFusion (+ the relevant mapping into Substrait) if it doesn't exist yet.
Seems like Arrow has a
containsfunction but I cannot find it in DataFusion so maybe it doesn't indeed exist yet, dunno if the Arrow version can somehow be easily used?
Sure, I'll file a PR later today
from arrow-datafusion.
richtia
commented on August 25, 2024
1
Yeah, duckdb has a contains function as well as the substrait support. The same substrait plans that gave me the datafusion errors were able to execute against the DuckDB substrait consumer.
from arrow-datafusion.
Lordworms
commented on August 25, 2024
Do we really need this conversion? what about adding a new ScalarFunction 'contains'? @alamb I would like to receive your advice here.
from arrow-datafusion.
richtia
commented on August 25, 2024
+1 to adding the function into DataFusion (+ the relevant mapping into Substrait) if it doesn't exist yet.
Seems like Arrow has a
containsfunction but I cannot find it in DataFusion so maybe it doesn't indeed exist yet, dunno if the Arrow version can somehow be easily used?
I didn't see the function in DataFusion either. I also couldn't find it in Arrow, at least not under any compute function.
from arrow-datafusion.
Lordworms
commented on August 25, 2024
+1 to adding the function into DataFusion (+ the relevant mapping into Substrait) if it doesn't exist yet.
Seems like Arrow has acontainsfunction but I cannot find it in DataFusion so maybe it doesn't indeed exist yet, dunno if the Arrow version can somehow be easily used?I didn't see the function in DataFusion either. I also couldn't find it in Arrow, at least not under any compute function.
I think DuckDB got a similar function, let me know if it is ok for me to implement similar behavior like thisfrom arrow-datafusion.
Related Issues (20)
- DataFusion weekly project plan (Andrew Lamb) - Aug 12, 2024
- Disable `create_default_catalog` when the exist session state has default catalog for `SessionStateBuilder` HOT 1
- Improve performance of `REPEAT` functions HOT 2
- Internal error: Empty iterator passed to ScalarValue::iter_to_array HOT 1
- `optimize_projections` fails when eagerly selecting from a join with ambigious column names HOT 1
- Speed up rpad implementation to use StringBuilder HOT 1
- Remove unused config value `scalar_update_factor` HOT 1
- 在文件prost.rs文件中定义的"pub struct Schema"等结构体，需要使用"#[derive(Serialize)]"属性生成序列化的方法。 HOT 3
- Improve error message for invalid aggregate queries
- Support different aggregate expression (outside SELECT list) in ORDER BY list HOT 2
- Allow suppling a table schema to ParquetExec HOT 7
- Panics in `MIN()/MAX()` aggregate functions (SQLancer) HOT 3
- Internal error in `approx_percentile_cont()` aggregate function (SQLancer) HOT 2
- Invalid aggregate SQL query with `HAVING` can be executed without error (SQLancer-TLP) HOT 3
- Unable to access LogicalPlanBuilder.plan inside a new trail implementation
- Make properties in phyiscal-plan/aggregates public
- COUNT(expr) always returns the COUNT(colname) HOT 7
- Convert built-in `row_number` to user-defined window function
- Improve performance of SUBSTR for StringViewArray HOT 3
- Empty strings in CSV files aren't being interpreted as null when using a `Dictionary(_, Utf8)` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from arrow-datafusion.