Code Monkey home page Code Monkey logo

Comments (4)

rtyler avatar rtyler commented on August 26, 2024 1

arrow 52 has been released with the fix but the underlying Invalid comparison operation still crops out. I'm trying to trace the code up through LogicalPlanBuilder to find the source of where the error is being generated 😕

from arrow-datafusion.

marvinlanhenke avatar marvinlanhenke commented on August 26, 2024

I just skimmed this real quick, so I might be wrong here.

But might the issue be rooted at arrow-rs itself:
https://github.com/apache/arrow-rs/blob/master/arrow-ord/src/cmp.rs#L219-L223

l_t.is_nested() in our case - which should return the Err.

@alamb @tustvold

from arrow-datafusion.

jayzhan211 avatar jayzhan211 commented on August 26, 2024

I just skimmed this real quick, so I might be wrong here.

But might the issue be rooted at arrow-rs itself: https://github.com/apache/arrow-rs/blob/master/arrow-ord/src/cmp.rs#L219-L223

l_t.is_nested() in our case - which should return the Err.

@alamb @tustvold

The next arrow-rs release will support nested comparison apache/arrow-rs#5792

from arrow-datafusion.

alamb avatar alamb commented on August 26, 2024

The next arrow-rs release will support nested comparison apache/arrow-rs#5792

It seems like the distinct kernel still does not support nested comparisons (which is fine) but that is the reason #11117 was needed. :

https://github.com/apache/arrow-rs/blob/main/arrow-ord/src/cmp.rs#L235-L238

I filed apache/arrow-rs#5960 to track adding this

from arrow-datafusion.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.