Comments (6)
Thank you for creating this ticket to facilitate the discussion.
For the general audience: The good news is that we found a way to support the old syntax simultaneously with the new options syntax -- the bad news is that it results in code complexity/maintenance burden.
Basically, the aim of this ticket is to gather information on usage so that we can decide whether it is worth to have both syntaxes supported for a while -- or should we just pull the band-aid and remove the old syntax.
from arrow-datafusion.
I agree that it makes sense to "pull the band-aid" and remove the syntax from this code.
One place where I think this might get difficult is if an project that relies on DataFusion has some sort of user/external input that relies on this syntax, that the project itself doesn't have the ability to easily change. But the nice thing about DataFusion is its extensible, so I could imagine if someone has a strong requirement to keep the old syntax, we could write a custom parser that wraps DFParser
(maybe lives in another repo, or in examples) that adds it back and just sets OPTIONS('format.has_header' 'true')
. (See an example of a custom parser at https://github.com/apache/datafusion/blob/main/datafusion-examples/examples/sql_dialect.rs#L45)
from arrow-datafusion.
IIRC, some of this original syntax came from a desire to suppor Hive SQL, but as @phillipleblanc said, if anyone needs this then they can add it back under a specific dialect.
from arrow-datafusion.
But the nice thing about DataFusion is its extensible, so I could imagine if someone has a strong requirement to keep the old syntax, we could write a custom parser that wraps DFParser (maybe lives in another repo, or in examples) that adds it back and just sets OPTIONS('format.has_header' 'true'). (See an example of a custom parser at https://github.com/apache/datafusion/blob/main/datafusion-examples/examples/sql_dialect.rs#L45)
Agreed, sounds like a reasonable way forward in case removing the old syntax creates challenges for certain users that can't change their SQL.
from arrow-datafusion.
If there is consensus here, given we just branched for the 38 release, maybe we can remove support on main now as part of #10404 and let that sit on main for a while ๐ค
from arrow-datafusion.
Sounds good. We will update the PR tomorrow ๐
from arrow-datafusion.
Related Issues (20)
- Building time for `cargo bench` takes quite a long time HOT 1
- Potential optimization for CASE WHEN for protecting against divide by zero HOT 1
- Add a sub-project for map udf functions HOT 5
- always failed test on datasource::file_format::csv::tests::test_csv_parallel_one_col::case_6 on windows machine
- Update Optimizer documentation HOT 1
- Implement `evaluate_bounds` for math unary functions HOT 2
- Why is there no content in `Extending DataFusionโs operators: custom LogicalPlan and Execution Plan` HOT 4
- Add NullState::is_null public method
- Typo in doc of datafusion::physical_plan::Partitioning HOT 2
- Expression Simplifier doesn't consider associativity (`(i + 1) + 2)` is not simplified to `i + 3`) HOT 5
- Serialization of UDF might lose aliases HOT 1
- Propagation of ordered `SortProperties` should consider `nulls_first`
- Rename `functions-array` to `functions-nested` to collect all nested-type functions HOT 2
- Consider having `SessionCatalog` also implement `FunctionRegistry` rather than providing access to the hash maps directly
- Review code that `downcast_ref` from `CatalogSession` to `SessionState`
- DataFusion weekly project plan (Andrew Lamb) - July 22, 2024 HOT 1
- Write a blog post about implementing StringView in DataFusion
- Optimize CASE expression to produce dictionary-encoded arrays in some cases HOT 1
- Decimal256 type is not supported in datafusion-proto
- Ability to chunk download from object store HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from arrow-datafusion.