Code Monkey home page Code Monkey logo

Comments (8)

jedcunningham avatar jedcunningham commented on July 1, 2024 2

#40314 will fix 8.0.0-8.0.19. However, if you are using 8.0.0-8.0.19, I'd highly recommend you upgrade since it's over 4 years old at this point.

from airflow.

potiuk avatar potiuk commented on July 1, 2024 2

That feels like a low blow @potiuk but on balance I think it's fair :)

:) I think we got quite a few "low blows" from MySQL over the past 4 years (starting from bad decisions about encoding, limiting the index sizes, locking far too many things during queries and causing deadlocks, bad handling and expiring of MySQL certificates in their apt repository that necessitated manually updating all past images we released for the last 4 years - the last one took 2 days of my life out ). I'd say they deserve some kind of retaliation :D

from airflow.

boring-cyborg avatar boring-cyborg commented on July 1, 2024

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

from airflow.

kaxil avatar kaxil commented on July 1, 2024

cc @jedcunningham @phanikumv

from airflow.

jedcunningham avatar jedcunningham commented on July 1, 2024

@EnableServices what version of MySQL are you on? I am not able to reproduce this failure, and MySQL 8 does support DROP CONSTRAINT (search for it in this page - can't deep link 😞).

from airflow.

potiuk avatar potiuk commented on July 1, 2024

#40314 will fix 8.0.0-8.0.19. However, if you are using 8.0.0-8.0.19, I'd highly recommend you upgrade since it's over 4 years old at this point.

Yet another reason why we should consider dropping mysql :) ?

I guess this is from (Changes in MySQL 8.0.19 (2020-01-13, General Availability)

When CHECK constraints were implemented in MySQL 8.0.16, ALTER TABLE supported DROP CHECK and
ALTER CHECK syntax as MySQL extensions to standard SQL for modifying check constraints,
but did not support the more general (and SQL standard) DROP CONSTRAINT and 
ALTER CONSTRAINT syntax for modifying existing constraints of any type. That syntax
is now supported; the constraint type is determined from the constraint name. (WL #12787)

from airflow.

EnableServices avatar EnableServices commented on July 1, 2024

That feels like a low blow @potiuk but on balance I think it's fair :)

On re-reading this page (https://airflow.apache.org/docs/apache-airflow/stable/howto/set-up-database.html), I can see that although it does suggest support for all versions of MySQL 8.0 - it does say "Old versions may not support all SQL statements."

Thank you @jedcunningham for the PR

from airflow.

jedcunningham avatar jedcunningham commented on July 1, 2024

Full disclosure: I have no idea if there are other queries that'll break as you start actually running Airflow. I only tested the migrations on an empty db :)

from airflow.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.