Add `json` and `sql` template rendering to Grid View about airflow HOT 12 OPEN

I also always wanted to contribute this but never came to this. I'd favor making this consistent like the DAG Run Conf which is rendered as a struct with a copy option.

Same applies for XCom results, too.

from airflow.

It has been made as a separate section in 2.9.1 in this PR. I guess the removal was intentional.

#39122

cc: @bbovenzi

from airflow.

@tirkarthi Hmm, that's a bit disappointing. I hate clicking more than times that I have to, or was previously used to.

from airflow.

Isn't rendered template available in details tab at the bottom? Is the new section missing some details from old page?

from airflow.

@tirkarthi Ah, ok, well, I suppose it depends on what is being rendered. For example, SQL being run via the BigQueryInsertJobOperator looks like this when you go to the specific rendered template page which used to be available from Details.

Whereas it looks like this now.

The important thing is that it's not possible to copy and paste the SQL directly from the UI and the previous page is now several clicks away.

from airflow.

Thanks, the legacy page uses renderers along with pformat which indents the dict. Maybe the issue can updated to have formatting for the values like the legacy page.

from airflow.

@tirkarthi It's not just about dict, but also the SQL contained within it. If the new page could render both in a similar way then great!

from airflow.

Yes, we should render the json and sql better in the grid view. We should add a copy button too.

from airflow.

@bbovenzi Great thanks! I'll change this to a feature request then.

from airflow.

I was working on this issue and it looks complex since the legacy page uses the task template fields to get the relevant renderer and uses pygment lexer for highlighting along with lot of other inference for the objects. The issue is that in this case there is configuration which is a json and configuration.query.query which is a sql with both of them template fields. But in the API response the rendered template field string is just returned without any lexer information. Also the legacy page has access to dagbag and the corresponding task which the API endpoints don't have.

I have made some progress on this issue and can raise a PR once I get to a working state.

Thanks

from airflow.

Another thing is that case in the fields in the response like bash_command is turned to bashCommand at the react layer which gets rendered in the UI as bashCommand which is also incorrect and a bug IMO.

from airflow.

I have created #39918 as a possible solution. Thanks.

from airflow.