Comments (11)
dstandish
commented on May 26, 2024
1
i was more curious about "the only question is whether we can cut it now or not"
i guess what you mean is, whether we can remove it immediately, or we simply deprecate it and leave it
from airflow.
dstandish
commented on May 26, 2024
1
I think we probably could just remove it. It would be sorta not too bad if someone was actually using it because the cluster would no run I think
so hopefully they'd discover very early in pre-upgrade testing
BUT it probably also doesn't hurt too much to just mark deprecated. @jedcunningham wdyt
from airflow.
abhishekbhakat
commented on May 26, 2024
We can close the PR #38709 if we decide to strip this feature completely.
from airflow.
abhishekbhakat
commented on May 26, 2024
cc @dstandish
from airflow.
jedcunningham
commented on May 26, 2024
I also commented in the PR, but I think we should just keep it scoped to TaskHandlerWithCustomFormatter (it's already documented that way fwiw). My 2c.
from airflow.
jedcunningham
commented on May 26, 2024
So the question is whether we can cut it now or not. It'd be possible for a user to swap in TaskHandlerWithCustomFormatter in airflow_local_settings, right?
I say we mark it as deprecated. Not sure on the removal though.
from airflow.
dstandish
commented on May 26, 2024
So the question is whether we can cut it now or not. It'd be possible for a user to swap in TaskHandlerWithCustomFormatter in airflow_local_settings, right?
sorry didn't understand @jedcunningham can you clarify?
from airflow.
abhishekbhakat
commented on May 26, 2024
I think we can remove it cause anyway it is unreachable code. So we can be sure no one is using it.
from airflow.
abhishekbhakat
commented on May 26, 2024
It'd be possible for a user to swap in TaskHandlerWithCustomFormatter in
airflow_local_settings, right?
Nah, it's inheriting StreamHandler which is not at all used for Task logs. Task logs are only FileHandlers. So no matter what settings we use in airflow_local_settings this will never work.
from airflow.
jedcunningham
commented on May 26, 2024
So the question is whether we can cut it now or not. It'd be possible for a user to swap in TaskHandlerWithCustomFormatter in airflow_local_settings, right?
sorry didn't understand @jedcunningham can you clarify?
If a user has replaced FileTaskHandler with TaskHandlerWithCustomFormatter for the task handler in airflow_local_settings, does it work?
from airflow.
jedcunningham
commented on May 26, 2024
Yep exactly.
from airflow.
Related Issues (20)
- Status of testing of Apache Airflow 2.9.1rc2 HOT 7
- DAG disappearing from Airflow in case of standalone DAG processor HOT 1
- Create new Callback Types HOT 2
- New release covering latest main HOT 1
- webserver static file caching is disabled above 2.3.0 version. HOT 2
- Status of testing Providers that were prepared on May 01, 2024 HOT 24
- Mock all connections in `TestYandexCloudYqHook::test_select_results` HOT 3
- This function is deprecated. Please use `create_unique_id`. HOT 2
- The "Set state to success" in the Task Instances view behaves differently than "Mark state as.. (success)" in Dag's detail view.
- Filter DAGs by tag (DAGs view) - Allow to use "AND" when filtering by tag
- Add a pattern-matching support for allow and block list in Datadog metric
- No LocalWorkers started when scheduler is launched in daemon mode. HOT 4
- Create `S3ToDynamoDBOperator` HOT 1
- Add ability to interact with OpenSearch in AWS HOT 3
- Issues with configuring airflow 2.6.3/python3.11 with LDAP HOT 4
- Display key in dynamic task mapping using dict in UI view of Mapped Tasks' map index
- Bug: `DataprocCreateBatchOperator` with `result_retry` raises `AttributeError` HOT 2
- Bad rendering of an inline code in the documentation HOT 2
- Extra metrics are being sent to DataDog when using Allow list with pattern matching enabled
- AirFlow Unit Testing not working as described in the documentation: HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from airflow.