Code Monkey home page Code Monkey logo

Comments (9)

Manno15 avatar Manno15 commented on June 11, 2024

Did you run the build script or did the rwalk script run the build script? That is what creates the jar and that dependency directory. I confirmed on my end, that the jar creation takes place on the latest commit.

from accumulo-testing.

milleruntime avatar milleruntime commented on June 11, 2024

Did you run the build script or did the rwalk script run the build script?

I did not run the build script manually.

from accumulo-testing.

milleruntime avatar milleruntime commented on June 11, 2024

I saw this again and after doing a build in testing, there is no jar:
accumulo-testing/target/dependency/hadoop-client-api.jar

The directory ../target/dependency does not exist. This is created by the shaded jar build:

[INFO] --- maven-dependency-plugin:3.1.2:copy-dependencies (default-cli) @ accumulo-testing ---
[INFO] Copying hadoop-client-api-3.2.2.jar to /home/mike/workspace/accumulo-testing/target/dependency/hadoop-client-api.jar
[INFO] Copying hadoop-client-runtime-3.2.2.jar to /home/mike/workspace/accumulo-testing/target/dependency/hadoop-client-runtime.jar

So this could be happening if a build occurred but the shaded jar didn't get built.

from accumulo-testing.

ctubbsii avatar ctubbsii commented on June 11, 2024

So this could be happening if a build occurred but the shaded jar didn't get built.

For reference, the shaded jar doesn't get built by default, it requires -Pcreate-shade-jar to activate that profile. The bin/performance script and conf/env.sh both activate this profile.

from accumulo-testing.

Manno15 avatar Manno15 commented on June 11, 2024

@milleruntime Is there anything actionable to be done on this issue?

from accumulo-testing.

ctubbsii avatar ctubbsii commented on June 11, 2024

I think the actionable thing is that if randomwalk requires the shaded jar, it might need to build it itself, or have instructions to build it.

from accumulo-testing.

milleruntime avatar milleruntime commented on June 11, 2024

I think the actionable thing is that if randomwalk requires the shaded jar, it might need to build it itself, or have instructions to build it.

The rwalk script already calls source "${bin_dir}/build" so I am not sure there is anything to be done.

from accumulo-testing.

ctubbsii avatar ctubbsii commented on June 11, 2024

Is it possible that build script won't build the shaded jar if there's another jar that's already present? If so, that could be fixed. Otherwise, yeah, there might not be anything to do here.

from accumulo-testing.

Manno15 avatar Manno15 commented on June 11, 2024

Is it possible that build script won't build the shaded jar if there's another jar that's already present? If so, that could be fixed. Otherwise, yeah, there might not be anything to do here.

That is correct. The build script will not re-build the jars if they are currently present. However, I haven't really run into the original issue in my testing. I can see there being a possible benefit to echo to the shell if the jar is present so a user could be more aware that they may have old jars present.

from accumulo-testing.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.