Format number? about github-profile-views-counter HOT 9 CLOSED

There is no way to determine who is doing request. All requests comes from GitHub proxy server with the same IP and User Agent.

from github-profile-views-counter.

If there will be the way to determine who is doing request, I'd better create unique visitors count instead of views count. And wouldn't increment counter on self visiting.

from github-profile-views-counter.

@JellyBellyDev good idea! And pretty easy to implement 😉

from github-profile-views-counter.

Number format was added.

from github-profile-views-counter.

Hey @antonkomarev What if we make 1000 to 1K, 10000 to 10K and so on this will be more readable.

Thinking ahead of time; instead of displaying 7329587, we should display 7.3 Million

This thread might be helpful https://stackoverflow.com/questions/9461621/format-a-number-as-2-5k-if-a-thousand-or-more-otherwise-900

from github-profile-views-counter.

@MuhaddiMu I've thought about it, but after counter will reach 1K you will stop seeing it's updates for a long time. And there is no way to insert detailed numbers in popup on hover.

from github-profile-views-counter.

That makes sense!

from github-profile-views-counter.

@MuhaddiMu but every day after seeing spam hammering my server I'm thinking about hiding detailed numbers. Maybe it will decrease amount of abuse.

from github-profile-views-counter.

Yes, this is a good point or maybe you can set some sort of throttling. A specific number of request in a minute for a specific user

from github-profile-views-counter.