incompatible to IntelliJ 2018 about jetbrains-plugin-st4 HOT 19 CLOSED

@bjansen I'm getting build issues.

beast:master:~/antlr/code/jetbrains-plugin-st4 $ ./gradlew buildPlugin
Error: Could not find or load main class org.gradle.wrapper.GradleWrapperMain

fixed in #15 please review changes and accept.

from jetbrains-plugin-st4.

Ok, done. 0.6 is up.

from jetbrains-plugin-st4.

dang. I guess I will have to take a look at 2018 some time for this and ANTLR. unfortunately my head is elsewhere at the moment.

from jetbrains-plugin-st4.

@bjansen, I think the issue can be closed because of #14. @bjansen Can you please publish new plugin version to the IDEA plugin repo?

from jetbrains-plugin-st4.

ATM only @parrt can publish new versions.

from jetbrains-plugin-st4.

Fixed by #14

from jetbrains-plugin-st4.

@bjansen I'm getting build issues.

beast:master:~/antlr/code/jetbrains-plugin-st4 $ ./gradlew buildPlugin
Error: Could not find or load main class org.gradle.wrapper.GradleWrapperMain

from jetbrains-plugin-st4.

let me check with clean env.

from jetbrains-plugin-st4.

@parrt yes, you right, there's no gradle-wrapper.jar under gradle/wrapper because of .gitignore

from jetbrains-plugin-st4.

Cool. got it. Building plugin now. worked. ok, so i should upload build/distributions/jetbrains-plugin-st4-0.6.zip add tag, bump version in .properties file and make release on github?

from jetbrains-plugin-st4.

I checked quickly that the plugin still works as expected when it's built by Gradle, but it's worth a second look before publishing, wdyt?

from jetbrains-plugin-st4.

Sure. let me try.

from jetbrains-plugin-st4.

Actually the change notes in xml file are not updated. i gotta fix that.

from jetbrains-plugin-st4.

BTW, I asked people at JetBrains why the plugin was only compatible with IntelliJ up to 2017.x, even if there was no upper bound in plugin.xml, and there was no clear answer:

I'm going to go out on a limb here and say that it's probably because the repo scans for APIs used (to determine product compatibility) and has decided that the plugin uses APIs that are no longer available.

and

in this case, "until-build" was modified manually on plugin repository. trying to find out "why", though...

So it's still not clear to me why it "broke", and what exactly fixed it other than uploading the jar again. I'm not sure the Gradle build "fixed" anything (it certainly improves the build process a lot though).

from jetbrains-plugin-st4.

ok, thanks. fixed, rerelease 0.6, pushing to plugin repo

from jetbrains-plugin-st4.

Wow. cloudfront exception trying to push.

from jetbrains-plugin-st4.

uh, i can't find when i browse repos. i changed this:

<idea-version since-build="143.0"/>

Like we have for antlr plugin. was this wrong?

from jetbrains-plugin-st4.

Updated to 2018.3.3 and it works.

from jetbrains-plugin-st4.

133 was IntelliJ 13, and 143 is 15 (see https://www.jetbrains.org/intellij/sdk/docs/basics/getting_started/build_number_ranges.html).

since-build was bumped in the antlr plugin because of API incompatibilities IIRC, it was probably not mandatory for the ST plugin. OK it was necessary because antlr 4.7 needs java 7.

from jetbrains-plugin-st4.