Code Monkey home page Code Monkey logo

Comments (12)

OlegPopow avatar OlegPopow commented on May 21, 2024 1

Packages in Arch work properly (both classic and git) and remove the whole program - I checked. Nevertheless, I think that compiling with classic method (cmake, make, make install) should also uninstall 100% of installed files. This may cause unnecessary clutter. Maybe I'm blind but I don't remember this problem occurring earlier.

from antimicrox.

pktiuk avatar pktiuk commented on May 21, 2024

I will check whether is it reproducible on debian-based systems.

EDIT: deb package doesn't have these issues.

from antimicrox.

pktiuk avatar pktiuk commented on May 21, 2024

@gombosg
Does it occur on Fedora-based systems?

from antimicrox.

pktiuk avatar pktiuk commented on May 21, 2024

@Hir-design
How did you installed antimicrox?

from antimicrox.

Hir-design avatar Hir-design commented on May 21, 2024

This results from the building with cmake and make. If the program gives this option, I checked it, because I am a tester. I think that despite using packages, there shouldn't be such a situation. But you will do it as you think.

from antimicrox.

gombosg avatar gombosg commented on May 21, 2024

Does it occur on Fedora-based systems?

It can't since only files specified in the RPM specfile are copied to the system during install. Conversely, they are uninstalled, too. Only home folder stuff can remain like config files.

from antimicrox.

gombosg avatar gombosg commented on May 21, 2024

So yes, this is a (c)make issue in this case.

from antimicrox.

pktiuk avatar pktiuk commented on May 21, 2024

I have checked this for CMake and there are only empty directories left behind. No files are left behind.
(Except the last one which is not installed by AntiMicroX, it is just a report file generated by the system, so it will be probably automatically deleted later).

I will check how deleting directories could be handled by CMake.

from antimicrox.

pktiuk avatar pktiuk commented on May 21, 2024

@AntiMicroX/members
Have you tried to install AntiMicroX using cmake (sudo cmake --install .)?
In my case it doesn't seem to work very well. In terms of integration with system it doesn't look good, system uses pixelated version of icon, tray icon doesn't load properly.

obraz
There are problems with uninstallation (cmake doesn't support uninstallation by default, and we there is created a special build target deleting files). Moreover, to properly uninstall AntiMicroX we have to somewhere store install_manifest.txt and current uninstall target is just a complicated way of running

xargs rm < install_manifest.txt

Maybe we should just mark installation via cmake as something not recommended?
We could just add some additional instructions for packages and that should be enough for users willing to compile.
For us-developers installing using cmake is not very useful, because we can just run compiled AntiMicroX from build/bin to test changes.

from antimicrox.

zzpxyx avatar zzpxyx commented on May 21, 2024

I don't know too much about cmake, but personally I haven't used it for installing antimicro or AntiMicroX. I may be misunderstanding things here but essentially in order to properly uninstall stuff we'll have to know the manifest anyway, be it in a script we maintain or via package management systems.

from antimicrox.

pktiuk avatar pktiuk commented on May 21, 2024

Cmake doesn't use package management system, that's why it is such a messy solution.

from antimicrox.

pktiuk avatar pktiuk commented on May 21, 2024

Cmake is marked as not recommended way of installation due to problems with proper integration with system, messy uninstallation process (it is not controlled by any package manager, for uninstallation install_manifest.txt is needed, uninstallation leaves empty directories)

from antimicrox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.