Comments (6)
yeah, without context that'd have to be done through <NavBar active='/some-page' />
.
from deku.
I'm curious about this too. I started thinking about a <Link/>
component for my router, but without context
I can only think to:
import { Link } from 'my-router'
const ListOfLinks = ({ props }) => {
const { entities, location } = props
return (
<ul>
{ entities.map(entity =>
<li>
<Link to={`/entities/${entity.id}`} from={location} activeClass={'is-active'}/>
{ entity.name }
</Link>
</li>
) }
</ul>
)
}
Something has to be passed down starting at least at top-level components assigned to <Route/>
s. Maybe pass a location
object that <Link/>
uses to compute isActive
or pass Link
itself as a prop that internally references the Router
...
from deku.
... or at least was dynamically created by the router before being added to props
from deku.
Yeah we need to figure out a solution for it. I might just wrap all of these issues up into a single thread and summarise everything up until this point. I'm still thinking it could be best to just pass a context
object down like you would any other prop. It'd probably be easier to follow. Then we solve for the UX problem in v3.
Thoughts?
from deku.
I've created a primitive that I think essentially solves this problem: redux-subscribe. This let's you create context components that store values from the global state atom in their own local state.
This does require you to have a primitive for doing local state, but that is a bit easier to achieve than the general context problem.
from deku.
A bit late to the conversation. I didn't know there were talks about removing context.
For links, with my implementation of routing I need to have access to the router instance for it to tell me if a link is active or not. Because a router instance might not be stateless (if you don't treat the URL of the page as your source of truth), having it in context prevents the use of singletons and therefore keep things server-side friendly.
from deku.
Related Issues (20)
- State change triggered in `onRemove` method does not get rendered
- Hot module replacement docs are out of date
- "jsnext:main" in package.json isn't useful HOT 3
- Idea for window/document listeners, and possibly context/state
- displaying svg problem
- Prevent component from re-rendering on change HOT 3
- consider aliasing className HOT 2
- diff.diffNode() should return empty array when no changes
- Access DOM node in onCreate HOT 4
- Cannot npm install from github HOT 2
- Deku Override
- Provide single builded file
- 404 http://dekujs.github.io/deku HOT 5
- what happend? HOT 3
- onRemove called after DOM elements have been removed
- The first path and second path from render function unequal HOT 3
- ParseError: 'import' and 'export' may appear only with 'sourceType: module' HOT 1
- Link to docs http://anthonyshort.me/deku/ is 404 HOT 2
- Cannot read property 'forEach' of undefined
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from deku.