Use errors instead of panic about xpath HOT 4 CLOSED

antchfx commented on June 12, 2024

Use errors instead of panic

from xpath.

Comments (4)

zhengchun commented on June 12, 2024

hi, @beikege , which method ? or provide an example. Thanks.

from xpath.

beikege commented on June 12, 2024

例如:

xpath/xpath.go

Lines 97 to 103 in 077bca4

    
           func Select(root NodeNavigator, expr string) *NodeIterator { 
        
           	exp, err := Compile(expr) 
        
           	if err != nil { 
        
           		panic(err) 
        
           	} 
        
           	return exp.Select(root) 
        
           }

修改为:

func Select(root NodeNavigator, expr string) (*NodeIterator, error) {
	exp, err := Compile(expr)
	if err != nil {
		return nil, err
	}
	return exp.Select(root), nil
}

这样会造成代码不兼容,我没想到其他好方法.

from xpath.

zhengchun commented on June 12, 2024

你可以直接使用xpath.Compile()实现自已的Select方法，你上面的代码可以在自已的项目中定义。

func Select(root NodeNavigator, expr string) (*NodeIterator, error) {
	exp, err := Compile(expr)
	if err != nil {
		return nil, err
	}
	return exp.Select(root), nil
}

from xpath.

beikege commented on June 12, 2024

感谢,希望发布大版本时用error代替panic.

from xpath.

Use errors instead of panic about xpath HOT 4 CLOSED

Comments (4)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	func Select(root NodeNavigator, expr string) *NodeIterator {
	exp, err := Compile(expr)
	if err != nil {
	panic(err)
	}
	return exp.Select(root)
	}