Code Monkey home page Code Monkey logo

Comments (4)

kk-at-redhat avatar kk-at-redhat commented on July 23, 2024 1

Actually, most of the modules I worked with so far are fine.

These work as expected: template, project, organization, group, credential type, credential (without password), inventory source, user (without password), instance group, settings.

I'll try to contribute if I have some free cycles.

from awx.

thedoubl3j avatar thedoubl3j commented on July 23, 2024

after looking back at the previous issue, this might be how check mode is interpreting present since it is set as default. Check mode might be a fresh environment every time so with the default state as present on these modules, check mode is reporting back that yes I would make the change. I am not sure if check mode necessarily should be idempotent in this sense.

from awx.

kk-at-redhat avatar kk-at-redhat commented on July 23, 2024

I'm sorry, I can't agree with that. If all provided fields are the same in the existing object, Ansible should be reporting "OK" in both real and check mode. Just like all the other modules in this collection do.

from awx.

thedoubl3j avatar thedoubl3j commented on July 23, 2024

Some modules are wrong and we should absolutely change that so the behavior is consistent across the collection but check mode at its definition is not idempotent. We are not actually changing anything so therefore, the change will "always" occur in a check run because it has no concept of the previous check run.

I will amend my previous statement that the 2 issues you opened are separate completely #14923 and I will answer separately there.

I would open a new issue for the entire collection and close this one since this is more specific to these modules when in reality, the whole collection has issues around our inconsistent support of check mode.

from awx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.