Code Monkey home page Code Monkey logo

Comments (7)

decentral1se avatar decentral1se commented on May 31, 2024 1

It is best effort right now. You can open a ticket with a spec of what you prefer to see and if someone wants to pick it up, I'd be glad to merge it. Right now, I am just holding on in maintenance mode on this code and trying to keep it running. I agree it could be better re: your comments but I can't put more time into this. People are using this so please don't remove it.

from molecule-hetznercloud.

decentral1se avatar decentral1se commented on May 31, 2024 1

OK, sounds fine! Opened #38 to track 🚀

from molecule-hetznercloud.

decentral1se avatar decentral1se commented on May 31, 2024

CI/CD is in https://drone.autonomic.zone/autonomic-cooperative/molecule-hetznercloud?

This is written in the README.

from molecule-hetznercloud.

ssbarnea avatar ssbarnea commented on May 31, 2024

IMHO, documenting that somewhere something is running does not provide enough confidence. I see no checks running on pull requests and I know that all modern CI are able to report check status on github so maintainer can avoid merging broken changes.

Ideally all projects should also require one peer review before merging but I am aware that this may be a real problem for very small projects (like ones with one maintainer).

Any change to address the missing checks issue?

from molecule-hetznercloud.

webknjaz avatar webknjaz commented on May 31, 2024

@decentral1se if you don't have anything against GHA, I can submit a PR with it, mirroring what Drone does but with full GH integration. This seems easy.

from molecule-hetznercloud.

decentral1se avatar decentral1se commented on May 31, 2024

@webknjaz that would be nice, thanks for offering. Can you also maintain it?

from molecule-hetznercloud.

webknjaz avatar webknjaz commented on May 31, 2024

I like to believe that it won't need much maintenance. But I can help out occasionally if need be. I'm mostly interested in scalable maintenance solutions these days, meaning that I'm likely to spend some time on automation that would be reused across similar projects so I'll probably do that at some point. But for now, I'll just send a PR as I see it.
The only thing needed from you would be to go to the repository settings and create a secret for that token used in the integration tests so it could be referenced from the GHA workflows.

from molecule-hetznercloud.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.