Code Monkey home page Code Monkey logo

Comments (5)

Kai-Chen avatar Kai-Chen commented on July 22, 2024

What's the runtime environment? neo4j version etc.

from anormcypher.

siderakis avatar siderakis commented on July 22, 2024

I'm using Cypher Map Literals which is why mapFormat is encountering these unexpected types.

mapFormat also doesn't support (String, JsArray[JsObject[]])

It seems like the solution is straight forward, we just need to add a few more cases to mapFormat.

from anormcypher.

siderakis avatar siderakis commented on July 22, 2024
  implicit val mapFormat = new Format[Map[String, Any]] {
    def read(xs: Seq[(String, JsValue)]): Map[String, Any] = (xs map {
      case (k, JsBoolean(b)) => k -> b
      case (k, JsNumber(n)) => k -> n
      case (k, JsString(s)) => k -> s
      case (k, JsArray(bs)) if (bs.forall(_.isInstanceOf[JsBoolean])) =>
        k -> bs.asInstanceOf[Seq[JsBoolean]].map(_.value)
      case (k, JsArray(ns)) if (ns.forall(_.isInstanceOf[JsNumber])) =>
        k -> ns.asInstanceOf[Seq[JsNumber]].map(_.value)
      case (k, JsArray(ss)) if (ss.forall(_.isInstanceOf[JsString])) =>
        k -> ss.asInstanceOf[Seq[JsString]].map(_.value)
      case (k, JsObject(o)) => k -> read(o.toSeq)
      case (k, JsArray(ss)) if(ss.forall(_.isInstanceOf[JsObject]))=>   // handle JsArray[JsObject]
        k -> ss.asInstanceOf[Seq[JsObject]]
      case _ => throw new RuntimeException(s"unsupported type")
    }).toMap

from anormcypher.

Kai-Chen avatar Kai-Chen commented on July 22, 2024

Thanks!

For values of type Seq[JsObject], I think the returned map should be Map[String, Seq[Map[String, XXX]]] rather than Map[String, Seq[JsObject]]. That way the nested object graph is completely rendered without any JsValue left in it.

With some test code, this would be a great PR to submit, if you feel like it :)

from anormcypher.

Kai-Chen avatar Kai-Chen commented on July 22, 2024

Merged.

from anormcypher.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.