Undelivered Mail Returned to Sender,about anonaddy/anonaddy

luckydonald commented on June 10, 2024

Three issues here:

The bug
The fact that it leaks a stacktrace, hostname, installation details to the person/system mailing me
The error in the GUI shouldn't be lacking any information

from anonaddy.

willbrowningme commented on June 10, 2024

That failed delivery entry was created here - https://github.com/anonaddy/anonaddy/blob/master/app/Mail/ForwardEmail.php#L366-L376

I've just tested this replicating the same error and the sender of the email does not receive a bounce message.

When the ForwardEmail job is being run it means the message was already accepted into the mail server. So to the sender it will appear as if the message was delivered successfully.

I've just fixed that bug and also added the actual exception error message instead of the generic "please check the logs" message.

from anonaddy.

luckydonald commented on June 10, 2024

Permanent link to the stuff from above:

anonaddy/app/Mail/ForwardEmail.php

Lines 366 to 376 in 7becf1a

    
           $this->user->failedDeliveries()->create([ 
        
               'recipient_id' => $this->recipientId, 
        
               'alias_id' => $this->alias->id, 
        
               'bounce_type' => null, 
        
               'remote_mta' => null, 
        
               'sender' => $this->sender, 
        
               'email_type' => 'F', 
        
               'status' => null, 
        
               'code' => $exception->getMessage(), 
        
               'attempted_at' => now(), 
        
           ]);

I'm not sure if I understand correctly, you say there's no way the sender got that email?

Because that's just what I got back to my external mail I created to test the forwards.

from anonaddy.

willbrowningme commented on June 10, 2024

What is the QUEUE_CONNECTION set as in your .env file? Are you running with Docker or from the self-hosting instructions?

from anonaddy.

luckydonald commented on June 10, 2024

Good question.
am using the docker image and I don't think I did set it myself.
Likely can't check before Monday, but possibly empty?
As it's not documented in the readme there, I did not set it intentionally.

from anonaddy.

willbrowningme commented on June 10, 2024

Run docker compose exec addy anonaddy tinker and then enter config('queue.default');.

I suspect it will be sync which would explain it not being queued.

from anonaddy.

luckydonald commented on June 10, 2024

Yes, I could confirm it's set to sync.

from anonaddy.

willbrowningme commented on June 10, 2024

I've also just updated the catch statement to catch \Throwable instead of just \Exception in order to prevent any stack trace being leaked to the sender.

from anonaddy.

luckydonald commented on June 10, 2024

Will this make a release any time soon?
Currently I've rolled back to v0.14.0 as that one isn't blocking as many emails.

Notably it's blocking google account mails.

from anonaddy.

willbrowningme commented on June 10, 2024

Just pushed a new release now.

from anonaddy.

luckydonald commented on June 10, 2024

Thanks!
Could you also please bump the version in the docker repo?

Basically this line:
https://github.com/anonaddy/docker/blob/3de44c7adf9088d6ae5928bc4fc3cbfd1af696f5/Dockerfile#L3

from anonaddy.

Undelivered Mail Returned to Sender about anonaddy HOT 11 CLOSED

Comments (11)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	$this->user->failedDeliveries()->create([
	'recipient_id' => $this->recipientId,
	'alias_id' => $this->alias->id,
	'bounce_type' => null,
	'remote_mta' => null,
	'sender' => $this->sender,
	'email_type' => 'F',
	'status' => null,
	'code' => $exception->getMessage(),
	'attempted_at' => now(),
	]);