Comments (7)
Hi @richfelker
Can you attach a gcode sample file?
I took an ultra quick look and from what I can tell Cura will insert a G4
when it does this lift head cooling thing. That will make estimate cut each layer into its own sequence, but post-process
still works correctly.
Is this correctly understood?
I'm weary of adding stuff for handling special sequences because it's one of those "never ending chases" things. We could add a single sequence
option to the estimate command, making it combine all sequences into a single one. Potentially even a version taking a number of sequences to allow, after which all later delays will be combined into the last sequence. Would that be enough to solve the issue?
Best regards,
Lasse
from klipper_estimator.
Here is a sample: mintime_test_bad.gcode.txt
Yes, it inserts G4
, but I actually have an open bug against CuraEngine that it shouldn't do the dwell when the time spent lifting the head is already greater than the time it wanted to dwell; without this change, the feature is unusably slow. I think "no extrusion" is better logic for "this is not a new sequence", especially since you probably want to tolerate normal Z-hop too.
Personally I'd be okay wth the "single sequence" option since I don't do any timing of multi-sequences anyway. But I think an automatic solution would be nicer here since Z-hop is a fairly widely used feature (even if lift head for cooling isn't) and knowing the precise time spent on "hops" would be useful.
from klipper_estimator.
Sorry fat fingers! Didn't mean to close :)
I'll implement a sequence limit, as it's a more general option people can use.
Normal z hops don't show this behavior because it's dwells that cause a new sequence to be created. Successive dwells are also combined, such that each segment contains at least one move.
Best regards
Lasse
from klipper_estimator.
Ah, would it make sense for dwells just not to cause a new sequence anyway, as they're a sort of "travel" rather than "print" move?
from klipper_estimator.
The reason dwells cause a new sequence is actually mainly for temperature waits and such. The idea was that "unbounded waits" in the print start gcode would be counted outside of the "main run". I reckon we could probably separate G4
dwells, which are really more like delays, from these "unbounded dwells", and simply count them as part of the run they occur in. That should make the Cura feature work correctly as well.
I'd probably consider this a breaking change compared to the current behavior, so we'd need to do a major bump but that's not an issue.
Let me look it over in the code, I don't think it'll be much work to change.
Best regards,
Lasse
from klipper_estimator.
Thanks!
from klipper_estimator.
Released in 2.0.0. The test file looks to give correct output, and also, wow, that's a lot of time used just waiting 😅
Best regards,
Lasse
from klipper_estimator.
Related Issues (20)
- FR: Rename function HOT 1
- Use config.js if moonraker is not online HOT 1
- Display Popup Window with Estimate after Slicing/Export / Possible bug in layer time output HOT 1
- Increasing acceleration beyond machine's max acceleration still decreases the estimate of time taken to print HOT 2
- Issue with Release Version of Estimator Hanging when Piped in Command Line HOT 1
- Installation HOT 3
- Windows exe doesnt start HOT 2
- Error on 'M73 P0.000 R46': unable to parse 0.000 HOT 5
- max_accel_to_decel has been removed in newest klipper versions HOT 3
- Microsoft Defender says: Trojan:Win32/Wacatac.B!ml HOT 2
- Wrong max_accel_to_decel calculation in v3.7.x HOT 2
- [Feature request] Add support for object exclusions
- Won't open on windows 11 HOT 1
- incorrect estimate result HOT 1
- Estimated print time off by a lot/seemingly random amounts HOT 9
- override minimum_cruise_ratio some times HOT 2
- Add ability to pass total print time in seconds via gcode placeholder
- post-process doesn't seem to work. HOT 6
- How to EXTRACT dump-moves informations into an external file HOT 2
- Support for the acceleration change set by orcaslicer with Emit Limits in G-Code option HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from klipper_estimator.