Comments (9)
Migrations inherit from ActiveRecord::Schema
, which can run operations without methods. Anyways, I updated the code to be more robust to this scenario.
from strong_migrations.
Hey @ziaulrehman40, Strong Migrations is tested against Rails 5.1 (https://travis-ci.org/ankane/strong_migrations), so think something else in your app may be interfering with it.
from strong_migrations.
@checker
should be set on initialization, but maybe another gem is overriding it?
from strong_migrations.
It was working fine on 4.2 and 5.0, i can check what else ot updated while migrating on 5.1.
Though nothing really stands out, but I updated haml-rails
, pg
and added listen
gem.
Nothing else i can in my changelog. I can try reverting these gem updates/additions if that helps.
from strong_migrations.
No, didn't help. I undid all gemfile changes and still same.
from strong_migrations.
The error doesn't occur in the test suite or a fresh Rails 5.1 app, so all signs point to something in your app.
from strong_migrations.
Yeah i understand that, but we must hunt it down whatever it is.
I will try to spend some time on this and as soon as I find something i will report.
Just to add,
-
StrongMigrations.start_after
is set, and there are a few migrations that run just fine after this set timestamp value, and this specific one fails which is near end of the list(second last). -
If i comment this specific migration's actual migration stuff, it passes over it just fine.
from strong_migrations.
Oh found it...
If you look closely, you can see there is no def change
or def up
in the migration i have pasted above, that was the issue. wrapping migration in a def change
fixed it.
I am not sure how it was even working in older versions... this is confusing.
from strong_migrations.
Thankyou @ankane , this approach was what came to my mind when i was investigating, but you were super fast to push a commit. 👍
from strong_migrations.
Related Issues (20)
- lock_timeout + lock_timeout_retries + concurrent postgres indexes HOT 2
- safety_assured not ignoring custom checks when safe_by_default is true HOT 1
- [Idea] Checks for dangerous attributes HOT 1
- add_reference + index +disable_ddl_transaction! is an unsafe pattern? HOT 1
- [Idea] Apply `safety_assured` through `revert` HOT 2
- `StrongMigration.start_after` doesn't respect version on `revert` HOT 1
- Adding a column with a default value should is safe when use mysql(5.7) as database HOT 5
- [Idea] Show check link with error message HOT 1
- Lock timeout when using `add_column` with `enum` type HOT 2
- `add_reference` with concurrent index can be dangerous HOT 2
- [Idea] Provide custom message prefix/suffix message HOT 2
- [Idea] Should add_unique_constraint be considered unsafe? HOT 3
- `StrongMigrations.start_after` does not work HOT 1
- Consider appending to ignored_columns as a best practice HOT 1
- [Idea] Ignore migrations from non-supported adapters HOT 3
- [Idea] safety_assured should require justification HOT 1
- [Idea] Adding auto incrementing primary key does not guarantee that replicas generate the same primary key values (MySQL) HOT 4
- Getting an error complaining about MariaDB Version HOT 3
- [Idea] Add these changes as default in Rails HOT 1
- [Idea] Support custom checks on TableDefinition methods
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from strong_migrations.