[QUESTION] : Does Custom Checks don't run for safety assured blocks ? about strong_migrations HOT 10 CLOSED

Hey @bheemreddy181, this problem seems specific to remove_column custom checks, so I don't think it makes sense to change the current behavior. We could add an option to add_check that specifies if it can be overridden. Something like:

StrongMigrations.add_check(overridable: false) do |method, args|
  # code...
end

(with ideally a better name)

from strong_migrations.

Hey @bheemreddy181, safety_assured skips all checks, including custom ones. It allows developers to run any migration code.

from strong_migrations.

Is this something we want to enable for custom checks ?

from strong_migrations.

yes, that makes sense. you want to label this as an enhancement. if you are ok I could give a try but I need some inputs from you for creating a PR. Thanks for your time :-)

from strong_migrations.

@ankane any chance getting on to this?

from strong_migrations.

Hey @bheemreddy181, sorry for the delay. After thinking about it more, I don't think it makes sense to add a new concept (non-overridable checks) just for this use case. You're welcome to fork the gem and make this change for your app, but I don't think it's something I want to include in the main project at this point.

from strong_migrations.

@ankane Sure, Can you update the docs for the same.

from strong_migrations.

What would you change in the docs?

from strong_migrations.

Adding an exception for remove_column for custom checks?

from strong_migrations.

thanks, @ankane Happy weekend :-)

from strong_migrations.