[Idea] Warn on the addition of a validated foreign key about strong_migrations HOT 5 CLOSED

Going to close this out, but feel free to create a PR

from strong_migrations.

Hey @iamvery, thanks for the suggestion. I think this is best as a custom check. I imagine most of the time foreign keys need to be valid.

from strong_migrations.

Thanks for the response @ankane! I'm a little indifferent on this, but I understand your point. I'm indifferent, because I feel like if the purpose of this library is to protect users from themselves it might go so far to recommend against typical cases like this in the name of safety.

Strong Migrations detects potentially dangerous operations in migrations, prevents them from running by default, and provides instructions on safer ways to do what you want.

Either way, the custom checks are a great feature that we can take advantage of. Thank you!

from strong_migrations.

Reading about the issue more, agree that it'd be good for the gem to handle it, so happy to accept a PR. Since the validate option was introduced in Rails 5.2, the instructions will probably need to use execute in previous versions. There will need to be instructions for validating as well.

References:

• https://travisofthenorth.com/blog/2017/2/2/postgres-adding-foreign-keys-with-zero-downtime
• https://github.com/rails/rails/pull/27756/files

from strong_migrations.

Thanks for the follow up here! It's going to be a few days before I can dig in, but this sounds great 👍

from strong_migrations.