Comments (11)
Hey @chadwilken, thanks for the report ๐ This should be fixed on master.
from strong_migrations.
from strong_migrations.
@ankane I hate to be the bearer of bad news, but it seems like it doesn't alphabetize the columns. It doesn't throw an error however so it's a partial win. Happy to help debug the issue, but I have limited experience with Makara's internals.
from strong_migrations.
Are you sure you have task "db:schema:dump": "strong_migrations:alphabetize_columns"
in your Rakefile? I tested against Makara 0.4.0 and 0.3.10.
from strong_migrations.
Yea, but I am almost wondering if something is cached because if I open a rails console and run ActiveRecord::Base.connection.columns(:users)
I get the alphabetically ordered list of columns so it definitely could be something on my end.
from strong_migrations.
It should only alphabetize them during schema dump.
from strong_migrations.
Sorry I meant to say I loaded a console, and then prepended the StrongMigrations:: AlphabetizeColumns
module to check that it was all functioning properly. If I run a migration or do a db:schema:dump
the dump works but isn't alphabetized.
from strong_migrations.
Im not sure if it matters but Im on Rails 5.2.0. Even after a full restart and uninstall older versions of the gem just to be sure, it is not alphabetizing them. It's not the end of the world, but it is a really handy feature.
My Gemfile.lock looks correct
GIT
remote: https://github.com/ankane/strong_migrations
revision: d4a21d1f8e1ae916c27b5e2109dd80dc40ae5567
ref: d4a21d1f
specs:
strong_migrations (0.2.2)
activerecord (>= 3.2.0)
Rakefile
# frozen_string_literal: true
require File.expand_path('../config/application', __FILE__)
Rails.application.load_tasks
task 'db:schema:dump': 'strong_migrations:alphabetize_columns'
from strong_migrations.
Looks like it was specific to Rails 5.2. Should work with the latest commit.
from strong_migrations.
You are a gentleman and a scholar and I would like to buy you a beer sometime for your stewardship of open source.
from strong_migrations.
So I still had an issue and it turned out to be PostGIS related, I opened #46 to address these issues.
from strong_migrations.
Related Issues (20)
- `StrongMigration.start_after` doesn't respect version on `revert` HOT 1
- Adding a column with a default value should is safe when use mysql(5.7) as database HOT 5
- [Idea] Show check link with error message HOT 1
- Lock timeout when using `add_column` with `enum` type HOT 2
- `add_reference` with concurrent index can be dangerous HOT 2
- [Idea] Provide custom message prefix/suffix message HOT 2
- [Idea] Should add_unique_constraint be considered unsafe? HOT 3
- `StrongMigrations.start_after` does not work HOT 1
- Consider appending to ignored_columns as a best practice HOT 1
- [Idea] Ignore migrations from non-supported adapters HOT 4
- [Idea] safety_assured should require justification HOT 1
- [Idea] Adding auto incrementing primary key does not guarantee that replicas generate the same primary key values (MySQL) HOT 4
- Getting an error complaining about MariaDB Version HOT 3
- [Idea] Add these changes as default in Rails HOT 1
- [Idea] Support custom checks on TableDefinition methods
- Config values in non-Rails apps HOT 1
- Setting NOT NULL on an existing column documentation HOT 3
- Support for CockroachDB Adapter HOT 2
- target_postgresql_version not being set correctly HOT 1
- [Idea] Prevent index removal before concurrent index creation completes HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from strong_migrations.