Code Monkey home page Code Monkey logo

Comments (3)

LilyReile avatar LilyReile commented on September 26, 2024 1

Wow, @ankane, great response time.

I took another look. add_column isn't actually an issue since the only place postgresql_version is called is wrapped in a conditional for unless direction == :down: https://github.com/ankane/strong_migrations/blob/master/lib/strong_migrations/migration.rb#L17

You'll want to be careful checking the version in future, though.

from strong_migrations.

LilyReile avatar LilyReile commented on September 26, 2024
          This migration uses execute, which is not automatically reversible.
          To make the migration reversible you can either:
          1. Define #up and #down methods in place of the #change method.
          2. Use the #reversible method to define reversible behavior.

from strong_migrations.

ankane avatar ankane commented on September 26, 2024

Hey @DylanReile, thanks for reporting 👍 I was able to reproduce and fix the issue with add_index and auto_analyze, but not sure how to reproduce the add_column one. Can you give an example migration that fails to reverse?

from strong_migrations.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.