add condition to check that the application root is available in the DOM before prebooting about preboot HOT 6 CLOSED

Yes but if it takes more than 10ms to load the application's dom node after document.body is loaded it will fail. You can provoke this behavior if you add a "big" attribute value to the application's root domnode. But in the end you completely right:

"we might only need to add another condition to check that the application root is alive and well in the DOM"

So I'll rename this issue and try to work on a minimal reproduction repo when I find some time.

from preboot.

Maybe the issues only comes up for me caused by a big json object attached to my applications root node as attribute:

<application options="....big data to evaluate..."></application>

But the conceptual problem stays in my opinion.

from preboot.

Your opinion is a little misguided. The preboot code waits in a setTimeout loop until the body is ready, so to fit your use case, we might only need to add another condition to check that the application root is alive and well in the DOM.

In order to investigate your use case, please provide a minimal reproduction repo where preboot does not work or errors out. For all other applications, the first child in the body is generally available when the body is, at least by the time preboot needs it.

from preboot.

Preboot suffers from various kinds of race conditions; I described some of them in #82.

from preboot.

See PR #83

from preboot.

ok I think we can close this issue since @mgol great report #82 has much more details. PR #83 should be included.

from preboot.