Code Monkey home page Code Monkey logo

Comments (4)

tbosch avatar tbosch commented on March 29, 2024

Made parser aware of the wraps keyword, without adding sth to the AST yet.
See https://github.com/angular/angular/blob/master/tools/js2dart/src/parser.js#L32

Better solution could be to subclass the scanner of traceur to recognize the wraps keyword as well.

from angular.

tbosch avatar tbosch commented on March 29, 2024

Talked about this with @mhevery, and a better approach is the following:

  1. remove the additional syntax and make the JS side run directly, without wrappers
    • use Array, Map in sources (as those are the names of the types in JS)
  2. create a configuration file for the compiler when transpiling to dart that allows the following configuration for types like Map, Array:
    • rename the type
    • change method names to another name
    • replace method calls with a short dart snippet (i.e. inlining done by the transpiler)

For now, we probably don't need to change field reads/writes...

from angular.

tbosch avatar tbosch commented on March 29, 2024

The change to the parser mentioned above should be removed...

from angular.

angular-automatic-lock-bot avatar angular-automatic-lock-bot commented on March 29, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

from angular.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.