fromJson fails if string contains quotes about angular.js HOT 5 CLOSED

This is a bit more complicated...
I don't think it's a problem of fromJson() neither angular's parser (which is behind the fromJson() method)
I hope, proper escaping should be responsibility of the creator of the source string (i.e. server side script, that generate json response)

Try this:
var jsonString = '{"one": "with "quote""}';
eval('(' + jsonString + ')');

You will surely get error, because when interpreter execute this:
var jsonString = '{"one" : "with "quote""}'
Variable jsonString contains a string like that: {"one" : "with "quote""}
Then, the parser has no chance to figure out which quotes should be escaped and which not...

The solution is to generate a valid json string like that:
var jsonString = '{"one" : "with "quote""}';
var orLikeThat = "{"one" : "with \"quote\""}";

from angular.js.

the serializer should absolutely be responsible for creating proper JSON. I came across the errors above when working on the personalLog demo app. The app serializes log messages into cookies when a new message is entered and deserializes these cookies on page load.

For some reason when I include quotes in my message, I get the errors above. I haven't had the time to investigate the issue further yet, but one way or another this is a symptom of a bug in angular.

We need to investigate this further.

from angular.js.

I was playing around with your personalLog demo app (btw pretty nice example !!!), I found the bug with removing wrong items (already fixed), but I was not able to simulate the problem with serialization, could add a test case for that ?

console.log(fromJson(toJson({a: 'aa \'s'})));
console.log(fromJson(toJson({a: 'aa "s'})));
console.log(fromJson(toJson({a: "aa 's"})));
console.log(fromJson(toJson({a: "aa \"s"})));

This works fine, so I still hope, the problem is not inside fromJson...

from angular.js.

you are right, I can't reproduce it any more. I guess I messed up something, but given the simplicity of data manipulation in the demo app I can't think of a way that would allow me to force cookieStore to persist incorrectly escaped strings. oh well.. I'll close this issue for now.

Thanks for investigating this.

from angular.js.

Sounds good, we have solved the issue without any single commit :-D

from angular.js.