Comments (17)
we determined that it may be trying to bootstrap twice
from angular-hint.
I'm still uncertain about what is going on here. Our call to resumeBootstrap
seems to be what causes the thrown error (although the docs site still appears broken whether or not this error is thrown). Specifically, when the module ng
tries to instantiate ngLocale
the runBlocks
for ngLocale
is empty and causes an error.
from angular-hint.
I don't think that we are bootstrapping twice. I think that the bootstrapping of ngLocale
is failing.
from angular-hint.
Okay... I tried removing all of our hint modules to see if one of them is causing the error, and I still see it triggered. So it would have to be an error in the overall AngularHint logic.
from angular-hint.
I don't know very much about the angular-loader
, but I think that it, rather than the AngularHint
logic is causing this particular error. For me, building a hint-bundle
with just the injector logic calls doBootstrap
and attempts to instantiate the empty ngLocale
that cause the failure. @btford any insights with regard to the behavior of the loader?
from angular-hint.
I was wondering if I could reproduce this behavior by looking at other sites built with Angular. Both https://builtwith.angularjs.org/ and https://www.virginamerica.com/ are broken by the use of AngularHint, although all the module messages appear to work the same. @caguillen214, it seems like our first priority would be to look at these. Especially https://www.virginamerica.com/ seems to be a good example of how AngularHint could be used with a real application. However, both these sites do not have the same issue as the Angulardocs.
from angular-hint.
The https://www.virginamerica.com/ site is broken with the use of ngHintDom
and ngHintInterpolation
.
from angular-hint.
The builtwithangular site is broken with the use of ngHintDom
, ngHintEvents
and ngHintInterpolation
.
from angular-hint.
i'm wondering if it's angular-loader + ngLocale that's giving us problems.
from angular-hint.
For the docs site, definitely.
from angular-hint.
I'd focus on the issues you identified, and we can return to the ngLocale thing tomorrow when I'm back.
from angular-hint.
Ok, our plan will to be try to fix individual modules to get a solid demo going for one of these other sites.
from angular-hint.
👍
from angular-hint.
Update: the angular docs site was broken by using an outdated version of Angular loader. However, using the updated Angular loader (1.3) was incompatible with sites running Angular 1.2. Hence we created our own modified loader to work with both versions of Angular, see angular/batarang@e5e6677
from angular-hint.
The https://www.virginamerica.com/ site is broken with the use of ngHintDom and ngHintInterpolation.
ngHintDom is unfeasible except for the patching of action taking place directly within the controller in the current implementation. An alternative solution is being explored.
Issues with ngHintInterpolation were addressed and the module no longer breaks the virginamerica site.
from angular-hint.
The builtwithangular site is broken with the use of ngHintDom, ngHintEvents and ngHintInterpolation
Again, ngHintDom is being revisited, the problem with ngHintEvents is that older builds of Angular have different events, and ngHintInterpolation no longer stops the site from loading correctly (although it does cause harmless exceptions to be thrown - currently being investigated).
from angular-hint.
Closing since the angularjs.org issue is tracked in #88.
from angular-hint.
Related Issues (20)
- RFC: Improving hints related to $parse HOT 1
- causing infinite digests on angular material wesbite
- $watch override makes one-time bindings in expressions to never clear the associated watch HOT 2
- Incorrectly reports digest time HOT 2
- TypeError: Cannot read property 'name' of undefined at module.exports HOT 15
- Error when loading angular-hint with requirejs HOT 7
- Validate directive / component definition HOT 1
- Script Error in requirejs environment, cannot load angular-hint. HOT 2
- Not seeing any warning /Error on console.
- Log / Warn for naming collisions in registerables (directives, controllers, filters etc.)
- hint.js giving error, Cannot read property 'name' of undefined HOT 2
- A semicolon error
- dist angular-hint.js file to be used without requirejs? HOT 7
- NPM install fails HOT 1
- Reconsidering bower? HOT 4
- humanReadableWatchExpression error on app load HOT 2
- Why controllers, dom and directives not working? HOT 1
- "$event is undefined"
- Unexpected end of expression when using 'angular-ui-bootstrap' HOT 4
- A bower-angular-hint would be nice HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angular-hint.