Code Monkey home page Code Monkey logo

Comments (9)

btford avatar btford commented on May 5, 2024

–> https://github.com/angular/angular-hint-log

here ya go

from angular-hint.

ealtenho avatar ealtenho commented on May 5, 2024

Awesome! Thank you @btford. I started working on the messaging repo #17

I'm wondering if we should also have a shared place for functions like @caguillen214's spell checking function? I think several of his repos make use of that functionality? Or maybe that library (ddLib I think?) should be a separate node module akin to dom-interceptor.js so that it could be loaded separately?

from angular-hint.

btford avatar btford commented on May 5, 2024

I'm wondering if we should also have a shared place for functions like @caguillen214's spell checking function?

Yeah probably.

We should also check that something like @caguillen214's function doesn't already exist in npm.

from angular-hint.

caguillen214 avatar caguillen214 commented on May 5, 2024

I looked around the npm website and found https://www.npmjs.org/package/natural, which has a various number of string comparison functions. However, it has a lot more than we need (just the levenshtein distance) so should we really add the whole npm module if we're not going to use the whole thing?

from angular-hint.

btford avatar btford commented on May 5, 2024

We definitely want something more minimal, as opposed to a "kitchen-sink" module.

npm search levenshtein seems to have many options. check out some of those.

from angular-hint.

caguillen214 avatar caguillen214 commented on May 5, 2024

I've looked at some of the levenshtein packages and even the ones that are just levenshtein packages provide a few other methods that we really dont need. These packages are significantly more light weight than the 'kitchen-sink' packages.

We only need to calculate the LD and right now we have a function that does that, is it the best option to include a package from npm?

from angular-hint.

ealtenho avatar ealtenho commented on May 5, 2024

https://github.com/angular/angular-hint-events/issues/2 @caguillen214

from angular-hint.

ealtenho avatar ealtenho commented on May 5, 2024

#25 duplicate discussion

from angular-hint.

ealtenho avatar ealtenho commented on May 5, 2024

@caguillen214 refactored the duplicate functionality to use the suggest-it npm module.

from angular-hint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.