Code Monkey home page Code Monkey logo

Comments (4)

alexeagle avatar alexeagle commented on May 6, 2024

Oh, thanks for the heads up. I didn't know there was a legacy layout in the runfiles, we'll need to adapt for it in rules_nodejs. Filed the linked issue there

from angular-bazel-example.

jlisee avatar jlisee commented on May 6, 2024

Thanks! also I checked double checked my notes and when you are not using legacy paths you get layout without the __main__/external prefix (initial issue updated):

prodserver.runfiles/nodejs/bin/nodejs/bin/node
prodserver.runfiles/nodejs/bin/node

This should be fixable in the code you have the templates the runfile shell script with the node paths.

from angular-bazel-example.

gregmagolan avatar gregmagolan commented on May 6, 2024

Thanks for the find. This should fix this issue: bazelbuild/rules_nodejs#380

Also related is a fix for karma to work with this flag: https://github.com/bazelbuild/rules_typescript/pull/309/files

And a fix for protractor will be required as will in the angular/angular repo

from angular-bazel-example.

gregmagolan avatar gregmagolan commented on May 6, 2024

Resolved in #227

from angular-bazel-example.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.